Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751687AbdH3Aht (ORCPT ); Tue, 29 Aug 2017 20:37:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:42266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdH3Ahs (ORCPT ); Tue, 29 Aug 2017 20:37:48 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A988214AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sre@kernel.org Date: Wed, 30 Aug 2017 02:37:45 +0200 From: Sebastian Reichel To: Liam Breck Cc: "H. Nikolaus Schaller" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Andrew F. Davis" , linux-pm@vger.kernel.org, linux-kernel , Discussions about the Letux Kernel , kernel@pyra-handheld.com Subject: Re: [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421 Message-ID: <20170830003745.6iimg4zn2cuybp7n@earth> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aex5j57exachm5ww" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2106 Lines: 61 --aex5j57exachm5ww Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Aug 29, 2017 at 01:20:27PM -0700, Liam Breck wrote: > Hi Nikolaus, thanks for the patch... >=20 > On Tue, Aug 29, 2017 at 1:10 PM, H. Nikolaus Schaller = wrote: > > Tested on Pyra prototype with bq27421. > > > > Signed-off-by: H. Nikolaus Schaller > > --- > > drivers/power/supply/bq27xxx_battery.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/sup= ply/bq27xxx_battery.c > > index b6c3120ca5ad..e3c878ef7c7e 100644 > > --- a/drivers/power/supply/bq27xxx_battery.c > > +++ b/drivers/power/supply/bq27xxx_battery.c > > @@ -688,7 +688,7 @@ static struct bq27xxx_dm_reg bq27545_dm_regs[] =3D { > > #define bq27545_dm_regs 0 > > #endif > > > > -#if 0 /* not yet tested */ > > +#if 1 /* tested on Pyra */ > > static struct bq27xxx_dm_reg bq27421_dm_regs[] =3D { > > I think we can drop the #if and #else...#endif so it's just the > dm_regs table, as with bq27425. Yes, please. -- Sebastian --aex5j57exachm5ww Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlmmCNkACgkQ2O7X88g7 +pr0Wg//VpAriTqjKTRT/wrdVfVGKp9AfnqFFFcCJf4K67YZn0AXQow+ODrXlpwm 0t1VOXKj0gDyIBTYzrmqcsaFP4BtQCIJXCJRHDv9jorjhrYCZAbe4rZawqew6nSa zf85a7+3z9KLTRwlAByo725HbBmTYek3r+t6YOHLWoCRXDObMAx4V2ZLx7Kf21Zx DV/gHfIsueJQnQnybHxAqcTiWRu3XnF2X+h2iFNR/BBk1LOOosj9oqVw+DjwrPWo fJRgSrBoTsP9zbj09l1MHbpKC8LUjZMCrTrvKEs0wUiSZCs5ZCoXVzERdIZsJpB5 hnXWp6gkcV1GDFOtEyha2GLeMnTDfda4/etoneFn3dZtu7wTIiSh/d6c3zFnanvc jjk+7KdHWbnGBRRx9xrUvPJwrn9JrG8SZJ/uoMqFwYfbCHh27Sq35HFNfF+JSaxG FxYITHJEqyrCFxl9PxuSwQwjVwsusAZNp/3GRNjTByBwxqovyRq1pZGrPJ0i/Tis wWV4khX/MF814dYtMD1hflMTzNOgNMVqku06v8io+aA0YcFNQK9LAfDpTt1Oq/oF InA59dmP+NCmAuSy6mows6CFZQzSPZDPO+ORhgZUbiEv6kRKKUXxtKMoZzbdpglW GRwQvM2RLTACK93qoFZbZO+ArpoDtgTKz5C7G7oYp/CSJ4Vdn7A= =DhwM -----END PGP SIGNATURE----- --aex5j57exachm5ww--