Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751789AbdH3AqE (ORCPT ); Tue, 29 Aug 2017 20:46:04 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:42517 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdH3AqC (ORCPT ); Tue, 29 Aug 2017 20:46:02 -0400 Date: Tue, 29 Aug 2017 17:45:29 -0700 From: Guenter Roeck To: Arvind Yadav Cc: jdelvare@suse.com, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: hwmon: ftsteutates: constify i2c_device_id Message-ID: <20170830004529.GA15111@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 868 Lines: 29 On Sun, Aug 20, 2017 at 12:56:34AM +0530, Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Appled to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/ftsteutates.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/ftsteutates.c b/drivers/hwmon/ftsteutates.c > index 0f0277e..317e45f 100644 > --- a/drivers/hwmon/ftsteutates.c > +++ b/drivers/hwmon/ftsteutates.c > @@ -60,7 +60,7 @@ > > static const unsigned short normal_i2c[] = { 0x73, I2C_CLIENT_END }; > > -static struct i2c_device_id fts_id[] = { > +static const struct i2c_device_id fts_id[] = { > { "ftsteutates", 0 }, > { } > };