Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752038AbdH3AuZ (ORCPT ); Tue, 29 Aug 2017 20:50:25 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36079 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbdH3AuX (ORCPT ); Tue, 29 Aug 2017 20:50:23 -0400 X-Google-Smtp-Source: ADKCNb72fmPEf2an6g7dKDUkxYnRvEl1RgQMrmYbY2V1Qhp5tkbkFcHaNj1rlwOxS1JhjrU5j1KomudYsLGg4XbE1WY= MIME-Version: 1.0 In-Reply-To: <20170829192915.26251-13-longli@exchange.microsoft.com> References: <20170829192915.26251-1-longli@exchange.microsoft.com> <20170829192915.26251-13-longli@exchange.microsoft.com> From: Pavel Shilovsky Date: Tue, 29 Aug 2017 17:50:21 -0700 Message-ID: Subject: Re: [Patch v3 12/19] CIFS: SMBD: Fix the definition for SMB2_CHANNEL_RDMA_V1_INVALIDATE To: Long Li Cc: Steve French , linux-cifs , samba-technical , Kernel Mailing List , linux-rdma@vger.kernel.org, Christoph Hellwig , Tom Talpey , Matthew Wilcox , Long Li Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1352 Lines: 38 2017-08-29 12:29 GMT-07:00 Long Li : > From: Long Li > > The channel value for requesting server remote invalidating local memory > registration should be 0x00000002 > > Signed-off-by: Long Li > --- > fs/cifs/smb2pdu.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h > index 18700fd..0417a36 100644 > --- a/fs/cifs/smb2pdu.h > +++ b/fs/cifs/smb2pdu.h > @@ -832,7 +832,7 @@ struct smb2_flush_rsp { > /* Channel field for read and write: exactly one of following flags can be set*/ > #define SMB2_CHANNEL_NONE 0x00000000 > #define SMB2_CHANNEL_RDMA_V1 0x00000001 /* SMB3 or later */ > -#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000001 /* SMB3.02 or later */ > +#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000002 /* SMB3.02 or later */ > > /* SMB2 read request without RFC1001 length at the beginning */ > struct smb2_read_plain_req { > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html If this is a bug in the existing code, this patch should go at the very beginning of the series. -- Best regards, Pavel Shilovsky