Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbdH3CLa (ORCPT ); Tue, 29 Aug 2017 22:11:30 -0400 Received: from mail-by2nam03on0076.outbound.protection.outlook.com ([104.47.42.76]:45198 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751669AbdH3CL1 (ORCPT ); Tue, 29 Aug 2017 22:11:27 -0400 Authentication-Results: spf=pass (sender IP is 208.19.100.21) smtp.mailfrom=microsemi.com; suse.cz; dkim=none (message not signed) header.d=none;suse.cz; dmarc=bestguesspass action=none header.from=microsemi.com; From: Raghava Aditya Renukunta To: Nikola Pajkovsky , dl-esc-Aacraid Linux Driver CC: "James E.J. Bottomley" , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2() Thread-Topic: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2() Thread-Index: AQHTIL47uqyfXbyASUmwW6f/9lc2M6KcKNmA Date: Wed, 30 Aug 2017 02:10:55 +0000 Message-ID: <4D8E82A446BF54499747901DBDEB737A8D0C199E@avsrvexchmbx1.microsemi.net> References: <29ed79bb97060429247eeafc9d6d8f6793a7f6b5.1504007944.git.npajkovsky@suse.cz> In-Reply-To: <29ed79bb97060429247eeafc9d6d8f6793a7f6b5.1504007944.git.npajkovsky@suse.cz> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.100.34.31] Content-Type: text/plain; charset="Windows-1252" MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:208.19.100.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(2980300002)(438002)(199003)(189002)(377454003)(13464003)(305945005)(356003)(97736004)(53546010)(8746002)(81166006)(106466001)(8676002)(626005)(81156014)(8936002)(33656002)(189998001)(6246003)(54906002)(9686003)(2906002)(104016004)(53936002)(2900100001)(69596002)(47776003)(23746002)(5660300001)(50986999)(54356999)(4326008)(53416004)(7736002)(86362001)(229853002)(7696004)(55846006)(478600001)(3846002)(76176999)(2920100001)(72206003)(68736007)(2950100002)(102836003)(50466002)(6116002)(5250100002)(6636002);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0201MB1491;H:avsrvexchhts1.microsemi.net;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD033;1:gwVO7JZLhOPqFUSVOHZQZJpEOnCms6BzAIFsCU93NFkWLO1OkgJlmn3HrljKWyqd4hpBxKl7mNWsZop+ZScpS8+CpvhrN16F6pN/BvK1I/xO3/78efGCeTdIbv+BU42j X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a910765a-a762-49e5-7ba9-08d4ef4c6a57 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(8251501002)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BLUPR0201MB1491; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1491;3:pfvvozxpiognMfHIz9FrIEAO8fFdfQLzxXeQGJYvWmTWHzE66BbJthKXina1tR3qKQrzVt7NGbgOe4ggrxgvRGst5DwctsCjRZcFpQkpL+8BgooCSA/k+Yvs1FCNJmGjDeyhU1ysr3a19/R+oQioOP8Kp5xvMqQeLZKi13STBGplCCqmi/PUQmGmcrZWJZEQHt33USpF+Th4Y8/bO9qyeS0Y8a31nSFgSU6o79iMXoz/45RLlnVhRu/JhQjlXa0vJPlh+Cyf6115+2lMXN8AG37bI2Z2n5rb5etDNlBOZCbjOUXZERuCJhCFfTI0eouNLbO2ZXW2l0o8XbAJWgD8HxC1ECcD3E8F5zTDxm6NpO8=;25:k9adHt8bEPflL9RVpsurohb9H/PUGUQOMR8zcrhmiyTbBYfDymgPYgHD0sIX8AI/EFd0i8349FImQvaFkqC8hUe8z/jJVAYvyd/Z77ou+SzMcz+wzG3saXqOjgrcCLzu4WDJ0bzXlxPK/PXEmRk8VAXM6D+Pb39Ddu9MwisNFx6kz2BI9bjSXJNjasK3nrvwGAiphaa8bmCDtlAvNpOTFBjbGYsxguRRX2Wjsb9LlDdjhrQyOmJKGr2mtfYZ/wHiutsXh/DRw/w5lkSFPWGvsYsXF2kP5tJ+PdEHNvzKIlZohmeJSbIIu/QbP2xXpP539eTM+yW8clP6t0y3JvEyIA== X-MS-TrafficTypeDiagnostic: BLUPR0201MB1491: X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1491;31:oIgz6FucQWinXdaUTYV4fgovRunN4ljL9woaGxyyck6E05CQTw1/06/mUAe3oNHOufJzuCSp0u/f5zOzYdgLcv0SKrHV+CdzirrZa5ziM39QHkr5OyC4WmTON4OAcmSJWbuEty22lVFv/SWC2f1KOyoZX1mo7E9fje6QnQQvVh8tCx7tBRCklih4AndLmZ8qaDlwpUiUC338kw9nkSunuID7h+fXOVR7W3OBuqiD2Rc=;20:z2C8exp/Dpn5pYcsPzsiGta9OIM6i7tTXnDi/cd4+ORBlK8EsYu97dFPbs9KRsZ9q2PH9Wb1XLjRjxXv44f65rrXd++IEv3lB0i2YalaCJ8lxKUUBS3yHEBGXH3wNsSQkyFRyQcg/eYHfptH9nOlg6OE8vwxj3o08FoUwRTIAa+bDRYuAKqK+SB0+oKA8wk6kpZDm/5dxmU1eOlXw8jBSKKYTKQBx+0WVur/DYLAThgWUaw6zHSXxBqd7rG/JPepihfEcVMFhtfyKLjgJqErY4nZkfjEMWpX9RIC3KB4GjnCD39Z8xjuK8qQvnzjoGFHJ/ahYKCK9yO71Cahrzfsi3IzJ61KMZj25xnukaii+24SY97NQUFPCTzeY+AgymXNB14D8X9FjRbAI8GvXTD7xUv7y2WXdBKXziv7YiF9CJwuSCwbUj5H/tb2KaWGiKHodapttA+fzXPdlEnKwYpPvuscx4tSWg1W3YhaZceXUTmxVlVG+6NeLQZ94uloODAd X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(72170198267865)(104084551191319)(146099531331640); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(13018025)(13016025)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93004095)(6055026)(6041248)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BLUPR0201MB1491;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BLUPR0201MB1491; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1491;4:gEbiSyZeQSYv1VmyQkhfhtjI5zDJwZVylH5krXAkulJK6OCC4uGdT2F+OwR3jtbT/AeqahdEGAvzz05IWAYaFjXvSv6/w6I4T8sbU3tPz0jLO9FUW7R37BDGLO8cdYYXlCPVHHiajd+4RbkWQ5zVQrOkFrfY1LlMQD3HPS4Vw2lGGmCD20QECQeGNHTU/yUx98h+DJcPtGcvyQcLdw01LuCZ8YoWVj6IxXG5PTyVafssqhHUXcjf+HbLXM4G9DXlmXET5XC7cOJzqUsRaj/sJSXF1eLJ3GPYmnZFtdSIQ+alWKbzvUhNBPonZfR7idHKoqgJG9G4MtO+8nDOgGgAv7oMNX/gvzXQTo5QF0k4VpZgBdK7RuTPWnJLgx5n8Dnylb5A98JQCCwkWbHfhuNKSg== X-Forefront-PRVS: 041517DFAB X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR0201MB1491;23:JDmk0tbCwgdVWN4PyYEVQXz7s/aBPkfeknp?= =?Windows-1252?Q?GHOrjHyMH+T7PH6c7IADeluNx9jcar2kjRnmTrSV4Czr2PzecelY2KkO?= =?Windows-1252?Q?AbJ5h8SY8iFlyf5uZ1Wbu67+FTlVs7S90ewFm4b1RtVbk1IPOPGaG9CU?= =?Windows-1252?Q?4NAfP3EqgDE6esggpUXOPrUj5QnTvkq6H7QJ2S/0Oo9xn/wfM7Tc4tyn?= =?Windows-1252?Q?EkYTBZK/aOFJrovUgoL3IwyFvJZljkMuQooKhzFk39Itl538yWU5vkus?= =?Windows-1252?Q?FaeKaVEfb/dlrA0ztuBF8mzbvrcL2HC6A+qlYV5pmZULZMFML84Rmq4N?= =?Windows-1252?Q?BAGJLDCaABwMy4ctStZJQUcqAMNOP2ygZlzbLgC7OF4CVHWABslBcq4h?= =?Windows-1252?Q?hfz1P7elFZ3kS7V24f3kdeSP+w+YB4cU/aFqxRiuUFGk6CUO02IZPgyJ?= =?Windows-1252?Q?Oh+4e8TDVcuvnZt78UOV1t/uzv5yGs9u3MZd2Ahmv/uj6T1uIXUMnbCu?= =?Windows-1252?Q?9aRmFNJ+vtPXD8WKF5+U3U9luzdClmDRudhsGAGxIcs7cTIUKTsgp2uX?= =?Windows-1252?Q?AJ0KPm2NJ8YXlZXCF6HrocsbWzXhCsUsZ0ebGxZqB3G+xEHoSWzd0VNz?= =?Windows-1252?Q?3YfLm76xcp3DIa32xw4sLw9nNVBwlqqqksg3S7QH245bRDxp+6ImbjML?= =?Windows-1252?Q?xskDmqsrdcX/F+kPfuV7uq1k8CHiC5rS74k/DIh+mdZBFA4dfTdwZQTj?= =?Windows-1252?Q?CRyD6kQt5yXFKuuFLECLOsckbsc7Q+ig+zbBwf6qGlCSNd9dtVQ+BjYJ?= =?Windows-1252?Q?2n+x6sav03bVzpvQ4qNT9LqUyyaTmwztIS2TVRGNEJMFXjNab1JYSH85?= =?Windows-1252?Q?hFw8J5oeFzcrUHyV9pOlTX1/rjBELiksGr9ox5ugLi3xM1TuHVdGbWCv?= =?Windows-1252?Q?6EcF5aBR0dV14VW7ZHRTP+qekifupREcMRjVrUtzNo+BgY5G/SjIK1RD?= =?Windows-1252?Q?Fty/x/oVF6jq7DZJtO96OuIPbYd6Q5ufa1QN9G7p6IZqKWVFQE+etJtZ?= =?Windows-1252?Q?hoFkZZQUshY/4tLLpVIZs0lNZHCdArb9fq+YlNt/02Px8A2IjGRJh78f?= =?Windows-1252?Q?P6G+1f1BZIdHSOdMadx26FtReDi72EEfSJnkN8sQAJ3FV3sOjVRRjBX+?= =?Windows-1252?Q?y/M8wl0++VW35iXWfpF5S5lXMBaPZT7Q5a4+4XGENmFJZyMP06Fjxf3k?= =?Windows-1252?Q?HcHANtaZnfe8c0tCZ0T8ObDP4OJivMEBlwTGbTYktJmMwZuxqOVaYsSo?= =?Windows-1252?Q?HNQi58D+dwcC28rrraZAQDSB8587dJP2TL3euLJ5jQsXnnN8=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0201MB1491;6:TvANzZ4zPytXjXsq8HQ/vlX35hXeWWQSWrRAAmY6436B/RR/TmzxAVHXEH6OtN4Tv7Ktqc9houN4ihA1rxFgO9y/g+lsdxGG6bScAuobjvy8ZPKP5kZgluduIcquwn0G52cSCFEZoTSw5K+jCOOuB8kuoBFin2DFIrEvEI4nzzAz+LfdQn5HT/97dgd0MrMp7jN8BwB60sCl8sep8Scwqp8TNRJUBG4zDkqNsIxfildQ3HrNmbvlzQUfzAYYmjUm1ME2yHtqKT3SB+TGzD4f2B293eL0PuXL0tycMRyEEcG41tFTh03YjmYYotvdoMmwBdAWytwtLDuVxOP23de55Q==;5:ndbSlFJ1Rxoe2FLlFqKTJ0p+GGQQCVxFQgZX28218/AO3zi0IywL//XhOSPLZZMHX/OZvdk6LugJQpTm+Vk0mdIWZS++BBZKvhqTvP2GKfuguenQ12eWGRMla47L22+AkqIrd+T0SOxwQCTuTMCjTQ==;24:3qEJ/NBuVyu2TKZku8rdHHzuQTrll/N/dCzyc8sLnFdTCVJDM/WH8IsLYvNBnBnkvGWQDSHuq0tt9PnLjSs3/a5A+WDW5Z2LlNvN09xGGr4=;7:dexKt4MO5wzO28uMpSL7Fq/do9LGnniSZOVDbZXz1PpuYBKhdZlyO3BvHES5+oWVTA4YgOanPikbcp+qfuGaOoLdKs7MqU0c6bGxKXvD5gn7kzbYMllajezOtHD2HV/KYLx1yusyB9oIZo5ghIKtG9jjwIjo84FoQ3AtfMNU9GXLY/IlLYL1f9H6c4vhwijwN/ZUv1srjxl77oldqisTMrLIIwk5P4nn674Z2lMZm6w= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsemi.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2017 02:11:24.3477 (UTC) X-MS-Exchange-CrossTenant-Id: f267a5c8-86d8-4cc9-af71-1fd2c67c8fad X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f267a5c8-86d8-4cc9-af71-1fd2c67c8fad;Ip=[208.19.100.21];Helo=[avsrvexchhts1.microsemi.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1491 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7U2BZMG001049 Content-Length: 854 Lines: 24 > -----Original Message----- > From: Nikola Pajkovsky [mailto:npajkovsky@suse.cz] > Sent: Tuesday, August 29, 2017 4:59 AM > To: dl-esc-Aacraid Linux Driver > Cc: Nikola Pajkovsky ; James E.J. Bottomley > ; Martin K. Petersen > ; linux-scsi@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from > aac_convert_sgraw2() > > EXTERNAL EMAIL > > > aac_convert_sgraw2() kmalloc memory and return -1 on error, which > should be -ENOMEM. However, nobody is checking return value, so with > this change, -ENOMEM is propagated to upper layer. > > Signed-off-by: Nikola Pajkovsky > --- [.....] Reviewed-by: Raghava Aditya Renukunta