Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbdH3CLs (ORCPT ); Tue, 29 Aug 2017 22:11:48 -0400 Received: from mail-bn3nam01on0121.outbound.protection.outlook.com ([104.47.33.121]:45027 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751240AbdH3CLp (ORCPT ); Tue, 29 Aug 2017 22:11:45 -0400 From: Long Li To: Pavel Shilovsky CC: Steve French , linux-cifs , samba-technical , Kernel Mailing List , "linux-rdma@vger.kernel.org" , Christoph Hellwig , "Tom Talpey" , Matthew Wilcox Subject: RE: [Patch v3 12/19] CIFS: SMBD: Fix the definition for SMB2_CHANNEL_RDMA_V1_INVALIDATE Thread-Topic: [Patch v3 12/19] CIFS: SMBD: Fix the definition for SMB2_CHANNEL_RDMA_V1_INVALIDATE Thread-Index: AQHTIP1Qlv2WCulkhE64bx9QaK/FfqKcEe+AgAAWpWA= Date: Wed, 30 Aug 2017 02:11:42 +0000 Message-ID: References: <20170829192915.26251-1-longli@exchange.microsoft.com> <20170829192915.26251-13-longli@exchange.microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=longli@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-29T19:11:40.9619275-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General x-originating-ip: [2001:4898:80e8:c::735] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MWHPR21MB0126;6:rSxhVgKV62lhGYDBYmGEb2GN6xqvAq6XBzxdM5MzhqYx9SpLGBFYR4oVVVoJRNv/92f5zCZM0yhyJwJeTjHD2Gt9v8P5msuYMqmdRRIVQr40Lq1WQIwwwRQvCYCIro4bKevaoZA3gdN/v/8YFD58UC4A1CXJv31sQGHMu0x9bdJZiGGxL/B/C5qMobT6UCnhHNt5vLYzYv0sprxWHA86IJtyn6dEEswybvrKl829Pq2XNN/gug5Tq5NwY8iFI+UHD7+Pv0sRZ9dA7LOpOGPgs9orjDgxkZ9wb0w/5Oxxy0KPEm8s3zaHNlIiRobcwEomwPXwVv/jEte359Xn5LhPmw==;5:EJQXb4nqZ4Lt0HpAUQ0gP6piDQminS5Lao8objwk3F3MgbiPT2XfOObAug2ApP1X9pbq9siI/3jltt1tdgh3QxFbZi7BukSDee0LuPfVTsaKIgmqwGaAXaHqCWSLPwR973FT8Sgai9NI97EiPg+L+w==;24:wI452uJAd7aHY6g0Q4RuoskBZg7nyfeJD8HRjo522Kg2GLf/gCKdQQgtyGN+tRS1yELa5d+4Zl5uQXWohKJPtabv84ubwbA6pfABUum4BgU=;7:vCrQLMSzCzOWEuc0NzW0dNhYTz/uiFXwo3RgjS6VW2SGV05ITpPhNLNrPAYzclLtbLpBohfveMi3G65gMQ2Zl3ufpVyj+/T3sLsSOk8FrRCi0oLYd4qzB5aShXMii3TIVJdX0Pzv0Q6dw5UE77G87q8lSeAgTjRjNRqy8By3lqrroM4JupuyEv8/o4mR2zxjWRsGr3/AmfRUSHhAqxnJjIcR9O84Cmjf2yiw6QCISVc= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: b00abbde-aed1-41a5-b248-08d4ef4c74e0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR21MB0126; x-ms-traffictypediagnostic: MWHPR21MB0126: authentication-results: spf=none (sender IP is ) smtp.mailfrom=longli@microsoft.com; x-exchange-antispam-report-test: UriScan:(158342451672863)(89211679590171)(9452136761055)(189930954265078)(140211028294663)(219752817060721); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR21MB0126;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR21MB0126; x-forefront-prvs: 041517DFAB x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(377424004)(13464003)(377454003)(189002)(6916009)(1411001)(39060400002)(53936002)(55016002)(99286003)(305945005)(54906002)(9686003)(6306002)(6246003)(107886003)(2900100001)(10090500001)(74316002)(53546010)(575784001)(110136004)(86362001)(5005710100001)(8990500004)(86612001)(229853002)(81156014)(50986999)(3660700001)(81166006)(8936002)(3280700002)(102836003)(97736004)(54356999)(8676002)(6116002)(2906002)(76176999)(7736002)(106356001)(68736007)(105586002)(966005)(77096006)(189998001)(6436002)(478600001)(10290500003)(25786009)(6506006)(4326008)(2950100002)(5660300001)(101416001)(14454004)(33656002)(7696004)(15760500002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR21MB0126;H:MWHPR21MB0190.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2017 02:11:42.2268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0126 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7U2Bs7E001053 Content-Length: 2417 Lines: 73 > -----Original Message----- > From: Pavel Shilovsky [mailto:piastryyy@gmail.com] > Sent: Tuesday, August 29, 2017 5:50 PM > To: Long Li > Cc: Steve French ; linux-cifs cifs@vger.kernel.org>; samba-technical ; > Kernel Mailing List ; linux- > rdma@vger.kernel.org; Christoph Hellwig ; Tom Talpey > ; Matthew Wilcox ; > Long Li > Subject: Re: [Patch v3 12/19] CIFS: SMBD: Fix the definition for > SMB2_CHANNEL_RDMA_V1_INVALIDATE > > 2017-08-29 12:29 GMT-07:00 Long Li : > > From: Long Li > > > > The channel value for requesting server remote invalidating local > > memory registration should be 0x00000002 > > > > Signed-off-by: Long Li > > --- > > fs/cifs/smb2pdu.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/cifs/smb2pdu.h b/fs/cifs/smb2pdu.h index > > 18700fd..0417a36 100644 > > --- a/fs/cifs/smb2pdu.h > > +++ b/fs/cifs/smb2pdu.h > > @@ -832,7 +832,7 @@ struct smb2_flush_rsp { > > /* Channel field for read and write: exactly one of following flags can be > set*/ > > #define SMB2_CHANNEL_NONE 0x00000000 > > #define SMB2_CHANNEL_RDMA_V1 0x00000001 /* SMB3 or later */ > > -#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000001 /* SMB3.02 > or > > later */ > > +#define SMB2_CHANNEL_RDMA_V1_INVALIDATE 0x00000002 /* > SMB3.02 or > > +later */ > > > > /* SMB2 read request without RFC1001 length at the beginning */ > > struct smb2_read_plain_req { > > -- > > 2.7.4 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-cifs" > > in the body of a message to majordomo@vger.kernel.org More > majordomo > > info at > > > https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fvger.k > > ernel.org%2Fmajordomo- > info.html&data=02%7C01%7Clongli%40microsoft.com% > > > 7C9a11066a2c3b402da09f08d4ef411927%7C72f988bf86f141af91ab2d7cd011d > b47% > > > 7C1%7C0%7C636396510253376659&sdata=0fLwHcdbOLSOsbKj5PZ2yrJap%2B > N0ZB%2B > > TGbFimPMqcx4%3D&reserved=0 > > If this is a bug in the existing code, this patch should go at the very beginning > of the series. Okay, I will reorder the patch. > > -- > Best regards, > Pavel Shilovsky