Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbdH3DPm (ORCPT ); Tue, 29 Aug 2017 23:15:42 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:5490 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbdH3DPl (ORCPT ); Tue, 29 Aug 2017 23:15:41 -0400 Subject: Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events To: Robert Richter References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com> <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com> <20170829124730.GH17961@rric.localdomain> CC: Ganapatrao Kulkarni , , , , , , , , , , , , From: Zhangshaokun Message-ID: <576d18ea-8fc3-9722-8cd7-b16d148211c0@hisilicon.com> Date: Wed, 30 Aug 2017 11:15:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170829124730.GH17961@rric.localdomain> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.221.148] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0202.59A62DC0.001C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1b83a0f4271642e5ada7ade8952aa44c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 36 Hi Robert, Got it and thanks your reply. Shaokun On 2017/8/29 20:47, Robert Richter wrote: > Shaokun, > > On 29.08.17 17:26:00, Zhangshaokun wrote: >> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: >>> This is not a full event list, but a short list of useful events. >>> >>> Signed-off-by: Ganapatrao Kulkarni >>> --- >>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ >>> .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ >>> 2 files changed, 77 insertions(+) >>> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv >>> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json >>> >> >> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion >> that would use vendor sub-folder? >> Of course, appreciate maintainer's comments. > > this would just add another level of subdirectories. I rather would > prefer to have a per platform dir comparable to what is listed in > > arch/arm64/Kconfig.platforms > > This is the same as Ganapat has implemented it. > > -Robert > >