Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752001AbdH3DXv (ORCPT ); Tue, 29 Aug 2017 23:23:51 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:39464 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdH3DXt (ORCPT ); Tue, 29 Aug 2017 23:23:49 -0400 Date: Tue, 29 Aug 2017 20:22:54 -0700 From: Guenter Roeck To: Arvind Yadav Cc: zwanem@gmail.com, wim@iguana.be, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: watchdog: sc1200: constify pnp_device_id Message-ID: <20170830032254.GA10447@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 26 On Wed, Aug 16, 2017 at 10:27:03AM +0530, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sc1200wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sc1200wdt.c b/drivers/watchdog/sc1200wdt.c > index b34d3d5..8e4e2fc 100644 > --- a/drivers/watchdog/sc1200wdt.c > +++ b/drivers/watchdog/sc1200wdt.c > @@ -342,7 +342,7 @@ static int __init sc1200wdt_probe(void) > > #if defined CONFIG_PNP > > -static struct pnp_device_id scl200wdt_pnp_devices[] = { > +static const struct pnp_device_id scl200wdt_pnp_devices[] = { > /* National Semiconductor PC87307/PC97307 watchdog component */ > {.id = "NSC0800", .driver_data = 0}, > {.id = ""},