Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750983AbdH3F6L (ORCPT ); Wed, 30 Aug 2017 01:58:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36948 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdH3F6K (ORCPT ); Wed, 30 Aug 2017 01:58:10 -0400 Date: Wed, 30 Aug 2017 07:58:14 +0200 From: Greg KH To: harsha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() Message-ID: <20170830055814.GA2458@kroah.com> References: <1504034462-13195-1-git-send-email-harshasharmaiitr@gmail.com> <1504034462-13195-2-git-send-email-harshasharmaiitr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504034462-13195-2-git-send-email-harshasharmaiitr@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 30 On Wed, Aug 30, 2017 at 12:51:02AM +0530, harsha wrote: > Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG() > > Signed-off-by: harsha > --- > drivers/staging/android/ion/ion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 93e2c90..a2d36b3 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev, > p = &(*p)->rb_right; > } else { > pr_err("%s: buffer already found.", __func__); > - BUG(); > + WARN_ON(); > } > } > As you did not do anything different from the last submission where I said this patch was not correct, I'm guessing that you don't want any feedback. So I'll go add you to my kill-file now and just ignore your emails, as obviously, you are ignoring mine :( good luck! greg k-h