Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751295AbdH3GKw (ORCPT ); Wed, 30 Aug 2017 02:10:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37774 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbdH3GKv (ORCPT ); Wed, 30 Aug 2017 02:10:51 -0400 Date: Wed, 30 Aug 2017 08:07:43 +0200 From: Greg Kroah-Hartman To: Sherry Yang Cc: linux-kernel@vger.kernel.org, "open list:ANDROID DRIVERS" , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , maco@google.com, tkjos@google.com Subject: Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function Message-ID: <20170830060743.GC3035@kroah.com> References: <20170830004702.120371-1-sherryy@android.com> <20170830004702.120371-2-sherryy@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830004702.120371-2-sherryy@android.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 664 Lines: 21 On Tue, Aug 29, 2017 at 05:46:57PM -0700, Sherry Yang wrote: > Use helper functions buffer_next and buffer_prev instead > of list_entry to get the next and previous buffers. > > Signed-off-by: Sherry Yang > --- > drivers/android/binder_alloc.c | 24 +++++++++++++++--------- > 1 file changed, 15 insertions(+), 9 deletions(-) What changed from the previous version? Always put the changes below the --- line. Like the documentation says to do so. Also, don't I already have these patches in my tree? Do you want me to revert the existing ones and use the new ones, or what about a fixup patch for any differences? confused, greg k-h