Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750890AbdH3GWA (ORCPT ); Wed, 30 Aug 2017 02:22:00 -0400 Received: from mail-dm3nam03on0063.outbound.protection.outlook.com ([104.47.41.63]:50596 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750756AbdH3GV6 (ORCPT ); Wed, 30 Aug 2017 02:21:58 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=thellstrom@vmware.com; Subject: Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops To: Arvind Yadav , airlied@linux.ie, syeh@vmware.com, linux-graphics-maintainer@vmware.com Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <63ab6910a20e486c69cf768b6d1bf8c8bc60149b.1504071891.git.arvind.yadav.cs@gmail.com> From: Thomas Hellstrom Message-ID: <5901b4a5-5eef-393f-7d18-704c037708c6@vmware.com> Date: Wed, 30 Aug 2017 08:21:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <63ab6910a20e486c69cf768b6d1bf8c8bc60149b.1504071891.git.arvind.yadav.cs@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [155.4.205.56] X-ClientProxiedBy: DM5PR13CA0028.namprd13.prod.outlook.com (10.168.240.142) To CO2PR05MB762.namprd05.prod.outlook.com (10.141.227.14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 253cd2c3-1ee8-430a-f95d-08d4ef6f68ed X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:CO2PR05MB762; X-Microsoft-Exchange-Diagnostics: 1;CO2PR05MB762;3:axCN4wDMoAqdfVhflhZE9NboWo1McoPfpfWAAWG1KWuJYzqMJlXE10N5KW+pBLssfgsHAhdR3gkomXzwEfGPRIAmY9QfPAv4enb/H7c5AEPYRLiyVqn356OHMRpMNjwlDzhM0EybwXWBZMrNOookYWNhqzK2NelJrD+pQbal77Zs7EDd7wjgN2ynEjd9dMv4X6Mhwk4yASwEd1TNtq9gyb6VrrxF18q5xqAw8ABPwhklA3KxwPEW3FBvRl8Wq/0A;25:zXQzcJx5QzoahjTBnt/XFicuNrefJ0CfAtP9c6Tw6wx+rjNjHDUlmKOwlqWYB6iifjW6khXmqXG8D3ALYu/dvFiVgsUU9IJiWH/8F1q5rYO/AWMX+d9KULqPwFy6CeM1iaf4a1T7EDDR+dwtr17zsSXRqZOfk04x0KSPmD/x2n8QzF4XtQwO8HxFCckb7YW3Kbt9l2UCUWJ2XEh9zwB7LZo+CIlG06qfYm5bZ7DjosGn6DUogYdvQbtCBcJlzpu7rFAPRc9frRm1DqUJpkjBPvJyxFx1CCCO/4rOFz7p4Jc9G9mn1sIq7Xa2XyWTk6u6NfdJ0zJzsgII5V39F/PKcQ==;31:2iwmUWhS2Ti3Y29r9R6JTvmOTAAFobmPWwdH6FA3g9FbeRSlhs/Up9q1DZRYvWbSfQv0X/yklaXUMzwF/nYxbnnmXnPdlOmAQmL6xEgH8pJCzozrJaEvUCXxyCPTIVJb+rQkP4RkjAWed5ZOc7z6DlZDaslR7F2VGzyxGlkF2YvYDTD/1gHsjDURftqYHTAxkc56K/o3cLD/Z3DMZ9AhyjWNYnCPuZeewhK+rVX1Vds= X-MS-TrafficTypeDiagnostic: CO2PR05MB762: X-Microsoft-Exchange-Diagnostics: 1;CO2PR05MB762;20:UPrKpqcrNeVf+r1P+8CGNkDmBASeVQudZDKtvZAEyp8KXHcZ9y5ATQOX96uXB2IXDR+4GjFQc3twWcCMgPsOVBSVHkpao7NZjuZiA9mWDlAIMS+HPQp8tvJXseH1iOblrTDDWz5i5DFFRzXv42J0gP9Kf/vDdJAOtidijLuAsw7MPDK58VICYcwXuJr2su/ryt/1XgPYx6acfBms9nFKc4cGKDVma0bTHya307q4I3yEl4dISOwl4RRVshyTk5gD+w4Wea5CNsMvPEey8ptqYaqwCfjEun7VbWJo4aqqi0Zg0HS4Pcd94gagYQaS8BFyGhfHGh3eox4CqA0vMDMzukbMoEqQBnSgEe/HEkMbvJoG8l0yCfFulkyp/39mjPTLH96W2+Uqz7wP20Bv6zNMxvwIY3/OFmwaCo+3KQ+drNSawM+6C+eVpC6mf+Py+B/2K8hDC1zIcOVQyf8QPMjzUjxabDLO8/w0ZYqmx3vPcvb4wMZWu3BzOeJY9Cels5Rl;4:winGvggZv+aU3Y6aR4qXEZXiYwEkuY+glphKzuz4ASRIjWCMPJUB/5o9H+EJXeSkroLjHQAEX7IWyYv+fDXz1he4CqdFQ8g5R4kxozmy83XwAwQDbRNN5phE164GtcyqhX3vo3u+vV9hvyiQKTR2hmsXbY1GTCWdEGrBoAJEIqOL64u4iQF1MyBdhML07tP0nNXBHfktrAArsz/9SlMkEtCI7y136z45Zcib2x7CNwg8mJ96NUQcUodJPN3wIP2HimVBU/wu+xbTTv8Jms+gaiAfJEKSOeOXcCkHBmLoHYI= X-Exchange-Antispam-Report-Test: UriScan:(61668805478150); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(201703131423075)(201703061421075)(201703161042150)(20161123564025)(20161123558100)(20161123562025)(20161123560025)(20161123555025)(6042181)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CO2PR05MB762;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CO2PR05MB762; X-Forefront-PRVS: 041517DFAB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(199003)(24454002)(189002)(377454003)(47776003)(97736004)(50466002)(6512007)(64126003)(229853002)(39060400002)(6506006)(68736007)(230700001)(4001350100001)(83506001)(6666003)(6636002)(66066001)(498600001)(6486002)(5660300001)(33646002)(65806001)(2906002)(6246003)(110136004)(65826007)(65956001)(31686004)(50986999)(76176999)(31696002)(105586002)(106356001)(54356999)(8936002)(101416001)(81156014)(81166006)(3846002)(7736002)(189998001)(53936002)(86362001)(2950100002)(4326008)(36756003)(23676002)(25786009)(53546010)(305945005)(42186005)(8676002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR05MB762;H:linlap1.host.shipmail.org;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjA1TUI3NjI7MjM6VzVKSmVqaHpKcURuUE9YNGVnMUM4cTVWU1lw?= =?utf-8?B?MEdmcnhLY05xRkRvV2lYdWZ2eDFWRVFRcUN2U3MraVQ3SGxIcEVVVFVROENz?= =?utf-8?B?UE1WcUVicFFmSGZTZHViSUM4bTBjSW1PVHNDWTBOZytaYkZJZ25MWFpNRE1U?= =?utf-8?B?azlaK0I0bkRQS0RTN3ZiMWI4Q2dCSTJ2RGRQQWZKUlFNMmJxRzBUTU9rbFRj?= =?utf-8?B?cnZVZ0N2YWl0WGp6bU9HckpPQ3lKczJSOXA1dkxkeDdNVVQ5WlBJdHJ1OWhL?= =?utf-8?B?VjMvU1V0NmRoZVNHMGpYbW5HK3YrOTUyaElTQWlBeEh4T01NVnFkZFZUN3FI?= =?utf-8?B?c0pRckVHVVhsa2gxNkJ4UWxvaXhLTlVpcnYzdC91YzNoSFV3S25YY1V0dHM3?= =?utf-8?B?TmRqdVBTbDZCU3kzbktFTEhkSk9xaHFwQ1A3a212MXRSRkx3WkRKcDVCL0F3?= =?utf-8?B?TlJXRmdTVmN3WjJ4TVkvdHZBaG1jSS9QSG0yUXVoSDYrem8wNDNlT2U3dVo4?= =?utf-8?B?djlCQVFEdE1YeEtocHlWaFRDMW43Z29RU3A5QzhldGhkQ3pxbU5pSjY5bWN0?= =?utf-8?B?YnVzUDhyMjBIYnJFWElKLzIxbWJKejQ0LzU1dkN0VGdjdmpIaXpTbVRLVWlw?= =?utf-8?B?VzRyREoyeGJ3Ly9VRHlJK3Q1Ym5VYTZQTm5yN2lDVWg2QW9lSVFpYm1BSFlx?= =?utf-8?B?N3pZWTJSVWdrQ1lJQkUvNk1XZno4b0wxeUNLOHNkbTZJbE5heVFtZU55TXVv?= =?utf-8?B?cUZFa2pmWFVLNFlIbjVDaHY5Rjg5TWJ5WWVFaC9wNG56RWx3N3dsVGs0Rjg2?= =?utf-8?B?QUUyQm1VMWx6RllwN0g1MTBGM3hZQVVLcHBlalA0dmFyRzBjR2dUWDhSNE9v?= =?utf-8?B?cDNtSWlKYnFKcUprY2tvUE05Rm8rbXNuOHVsQ3F3VkdQSWFyN3F0cVh2VGlS?= =?utf-8?B?U0xSVE0zbEd4ZStDM1dZVzlZaVF0dEVaVGU5WXk0RTMvRVBzalR5WjlHeHY3?= =?utf-8?B?MG9sME9XL0g4eGU3VlBnNW04UWFMRFFUZFZFWFpnTHBWSmpONnE3Nzl4ZEVa?= =?utf-8?B?bTNXYWN2MkRNQmd0Ukw0THh5blBPNlRHNE1ld0d5ajNYS0JRWlNtUFdEb0hu?= =?utf-8?B?M29jVFB4am5OREZJUXpVTUcvaXk0MzFMLzArU0VObDkyTmFJWWF6QTgzMzVo?= =?utf-8?B?STY5K3FCZXJickhzbTlIVFdiZFkxemxMWnhGSDNWWkRzTE4vSjNvVFFhd3FB?= =?utf-8?B?eXRxN0VoaVJvTDdIaEZvVG9aSnpOQUpaRUU1RkdCanBncjNFUkk3TnMxMjR4?= =?utf-8?B?UW4vMTEyYW9WblYyc1ZpVk9ESWVDcGtzbm9aOHgrb3psWE5rb2J5MzEzM1lU?= =?utf-8?B?SFJJYjZGUG8rSXBWNlAwRmlRa1gxU3V4NEF1aVdhT1BhdFA3VTl1ME1jb1Zm?= =?utf-8?B?M3NSa0tEV3U0TEVBMUtGeENIMU53U2lpNzlyRGJJN1Yzak9lbnArY1pTdXBZ?= =?utf-8?B?aXdJYkdmeDlHazNNRnhiR2h6OWp5T2JoNEMveXZ1Smd1dGpVd3luOXdRRnpE?= =?utf-8?B?bE9sY3BONjdma0RWUktZb2FRM0R3UUcwSVJrWGJLZUNDaWpud01aWWZWYnA3?= =?utf-8?B?K0dRRlN6SHpkSnFLZTBkUGl0NzNibzF0TjdzbWVuV2J3aGNMcnlTU1VPS1FK?= =?utf-8?B?Vnc5LzlVYkhtenR4QXF6bDlhTTdSajQ0R1V3dkdjUHFPWFliTDVLUU9jdEFJ?= =?utf-8?B?RENQZUtySGFjekNlZmcvYko5eGhxVlNHZ3NWeFA5dWsrWmZLYzU5cThwcmQ2?= =?utf-8?Q?G/SaogsPZx1h?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR05MB762;6:DUkDCy72RrZ7P8+Pksh2mCej2ExGAgONM9ilk/nuAbN+dz+oqqdLL+o7F6ejeK5xlOUfDbjYbE9I/Z2f3FKUoeRRZB5e0ftOyN7AVFmTS4dcXvvc+R47Cpv1UcizA920R8+9Q/r2jOqv9hHe6ajNaGYgB3SUc2qGHf0Sn1vmMT9Wo+7kl0B6xSBrZJaHXTdG6fDeibugNOKFP+vBLiQ6qkkNa1V+ou7tKlrJ86lLdR9TX3d8g4bjqK6al8FlEk3+QVd0LqwciNrXRz4RfJo24Sww4ZP5dyNzn+mWRvA2K1NZQ4bayT3IVU/kp+7zNgYXMYF9FAacStDKT/s6FRIFdA==;5:4eLBRa2TGZsXlapmAK0abO02g5A7kIQtXHUtq4gnU6EoFG4UGLd0iKNbtHYpkQkovIg0aIxGjIRMapHhc/CXgjJzY4LK+PsBtKXuGDXF2Zth50ie74UMyiIViJFaivIez102j+3Lk/p6jGYoq1eUsQ==;24:wb581k/nKjLUzifUeD9SzB/J3B/NOWun98e7WAnX76r/zdwIl8lD/IgcKa2PSEsxlMbxmz+5uJ7/84KXR3WVLYBqRR0EBDzFM3N1imOxhVQ=;7:noYaxNzEBwcx0ywvxpZBzxhXqZoK2h0aYVCre5ThUd8rYF9wXOf4/ScHZTRI2ye07Gdw48XcDRnBwBG1Hr+GlSFQnzXiAEzisf02YaQuyoTMGzhb7fwifJikfstUzszc70XVPaW/bXLum0+Zc5KrMNXKG5HLd8oEW+9+CzyQOH5uKKKkY7lOx7xVNw/j954gsGf4Wb1It9nbWvHr1YLZTlZEzHnTGIDDnXliuriop8U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CO2PR05MB762;20:LOnUgt36wgcSdKgC9OEElng4sId/RFAivxFQPuKj/4s1DEtZnbD5kZTY64+gFi4N4m9PPMt7AImm4uaret16GaxJidmPjj16EQx4S2hX/kGJcl/WGqSQNOf0POSGcgMnMPuzF+AzbKt9VBoRGISlcTgoCDxSUSI+BpHOzMaqW40= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2017 06:21:53.2229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR05MB762 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 26 On 08/30/2017 07:47 AM, Arvind Yadav wrote: > vmw_fence_ops are not supposed to change at runtime. Functions > "dma_fence_init" working with const vmw_fence_ops provided > by . So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > index b8bc5bc..abc5f03 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout) > return ret; > } > > -static struct dma_fence_ops vmw_fence_ops = { > +static const struct dma_fence_ops vmw_fence_ops = { > .get_driver_name = vmw_fence_get_driver_name, > .get_timeline_name = vmw_fence_get_timeline_name, > .enable_signaling = vmw_fence_enable_signaling, Reviewed-by: Thomas Hellstrom