Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbdH3Iaf (ORCPT ); Wed, 30 Aug 2017 04:30:35 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33567 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbdH3Iab (ORCPT ); Wed, 30 Aug 2017 04:30:31 -0400 Date: Wed, 30 Aug 2017 10:30:24 +0200 From: Daniel Vetter To: Thomas Hellstrom Cc: Arvind Yadav , airlied@linux.ie, syeh@vmware.com, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops Message-ID: <20170830083024.fokqszud2euwg476@phenom.ffwll.local> Mail-Followup-To: Thomas Hellstrom , Arvind Yadav , airlied@linux.ie, syeh@vmware.com, linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <63ab6910a20e486c69cf768b6d1bf8c8bc60149b.1504071891.git.arvind.yadav.cs@gmail.com> <5901b4a5-5eef-393f-7d18-704c037708c6@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5901b4a5-5eef-393f-7d18-704c037708c6@vmware.com> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1491 Lines: 36 On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote: > On 08/30/2017 07:47 AM, Arvind Yadav wrote: > > vmw_fence_ops are not supposed to change at runtime. Functions > > "dma_fence_init" working with const vmw_fence_ops provided > > by . So mark the non-const structs as const. > > > > Signed-off-by: Arvind Yadav > > --- > > drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > index b8bc5bc..abc5f03 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c > > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout) > > return ret; > > } > > -static struct dma_fence_ops vmw_fence_ops = { > > +static const struct dma_fence_ops vmw_fence_ops = { > > .get_driver_name = vmw_fence_get_driver_name, > > .get_timeline_name = vmw_fence_get_timeline_name, > > .enable_signaling = vmw_fence_enable_signaling, > > Reviewed-by: Thomas Hellstrom Does this mean you'll merge it, or does this mean you'll expect someone else to merge this? I'm always confused when maintainers reply with an r-b/ack for a patch only touching their driver, and no further information at all. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch