Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbdH3I7y (ORCPT ); Wed, 30 Aug 2017 04:59:54 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:65060 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbdH3I7w (ORCPT ); Wed, 30 Aug 2017 04:59:52 -0400 Subject: Re: [PATCH v3] mfd: tps65217: Introduce dependency on CONFIG_OF To: Javier Martinez Canillas References: <1504072208-28888-1-git-send-email-j-keerthy@ti.com> CC: Lee Jones , =?UTF-8?Q?Enric_Balletb=c3=b2_i_Serra?= , "linux-omap@vger.kernel.org" , Linux Kernel , Mark Brown , Tony Lindgren , Bartlomiej Zolnierkiewicz From: Keerthy Message-ID: <2bf0adc1-c44d-d98c-3e89-8a1e6488d588@ti.com> Date: Wed, 30 Aug 2017 14:29:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1626 Lines: 60 On Wednesday 30 August 2017 01:35 PM, Javier Martinez Canillas wrote: > Hello Keerthy, > > On Wed, Aug 30, 2017 at 7:50 AM, Keerthy wrote: >> Currently the driver boots only via device tree hence add a >> dependency on CONFIG_OF. This leaves with a bunch of unused code >> so clean that up. This patch also makes use of probe_new function >> in place of the probe function so as to avoid passing i2c_device_id. >> >> Signed-off-by: Keerthy >> --- >> >> Changes in v3: >> >> * Added more details to commit log. >> * No changes in code. Rebased to latest next branch. >> >> Changes in v2: >> >> * Cleaned up chip_id and data attached to the match. >> * Cleaned up i2c_dev_id >> * dropped the rest of the patches in series for now >> >> Boot tested and checked for regulator registrations on am335x-boneblack >> > > Did you check building as a module? Autoload won't work if you remove > the I2C device ID table. You are right! I tracked many of your patches that are already in master branch so assumed it to be working. Seems like not. Thanks for your feedback. > > [snip] > >> >> -static const struct i2c_device_id tps65217_id_table[] = { >> - {"tps65217", TPS65217}, >> - { /* sentinel */ } >> -}; >> -MODULE_DEVICE_TABLE(i2c, tps65217_id_table); >> - > > Unfortunately this can't be removed yet. We are getting there but > still some patches need to land. > > Rest of the patch looks good, so if you keep the I2C device ID table > feel free to add: > > Reviewed-by: Javier Martinez Canillas Thanks! > > Best regards, > Javier >