Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdH3JYm (ORCPT ); Wed, 30 Aug 2017 05:24:42 -0400 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:57497 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdH3JYm (ORCPT ); Wed, 30 Aug 2017 05:24:42 -0400 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.220.161 X-Original-MAILFROM: byungchul.park@lge.com From: "Byungchul Park" To: "'Peter Zijlstra'" Cc: , , , , , , , References: <20170823115843.662056844@infradead.org> <20170823121432.990701317@infradead.org> <20170824021840.GC6772@X58A-UD3R> <20170824140240.t4imrpvussebfimm@hirez.programming.kicks-ass.net> <20170825011114.GA3858@X58A-UD3R> <20170829085939.ggmb6xiohw67micb@hirez.programming.kicks-ass.net> <20170830020953.GE3240@X58A-UD3R> <20170830074117.GG3240@X58A-UD3R> <20170830085333.GM32112@worktop.programming.kicks-ass.net> <004601d3216e$a3702030$ea506090$@lge.com> <20170830091223.xxnh3podtcumlabm@hirez.programming.kicks-ass.net> In-Reply-To: <20170830091223.xxnh3podtcumlabm@hirez.programming.kicks-ass.net> Subject: RE: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation Date: Wed, 30 Aug 2017 18:24:39 +0900 Message-ID: <004701d32171$ce57d4c0$6b077e40$@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJwgPNBZSrwwUhgk1jM4IWrVNl3zAFx86IaAd+W3YgB43Hd9wGLNxGCAovBIH8CxViJIAHcH29vAmfLCDYB987kxQG4fGNNoMGylbA= Content-Language: ko Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1252 Lines: 30 > -----Original Message----- > From: Peter Zijlstra [mailto:peterz@infradead.org] > Sent: Wednesday, August 30, 2017 6:12 PM > To: Byungchul Park > Cc: mingo@kernel.org; tj@kernel.org; boqun.feng@gmail.com; > david@fromorbit.com; johannes@sipsolutions.net; oleg@redhat.com; linux- > kernel@vger.kernel.org; kernel-team@lge.com > Subject: Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation > > On Wed, Aug 30, 2017 at 06:01:59PM +0900, Byungchul Park wrote: > > My point is that we inevitably lose valuable dependencies by yours. > That's > > why I've endlessly asked you 'do you have any reason you try those > patches?' > > a ton of times. And you have never answered it. > > The only dependencies that are lost are those between the first work and > the setup of the workqueue thread. > > And there obviously _should_ not be any dependencies between those. A 100% right. Since there obviously should not be any, it would be better to check them. So I've endlessly asked you 'do you have any reason removing the opportunity for that check?'. Overhead? Logical problem? Or want to believe workqueue setup code perfect forever? I mean, is it a problem if we check them? > work should not depend on the setup of the thread. 100% right.