Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdH3JbC convert rfc822-to-8bit (ORCPT ); Wed, 30 Aug 2017 05:31:02 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:26539 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbdH3JbB (ORCPT ); Wed, 30 Aug 2017 05:31:01 -0400 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcecEarQROEYabkiUo6mSAGQ+qKID8zPHsMfA== X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH resend v2] power: supply: bq27xxx: enable writing capacity values for bq27421 From: "H. Nikolaus Schaller" In-Reply-To: Date: Wed, 30 Aug 2017 11:30:57 +0200 Cc: =?utf-8?Q?Pali_Roh=C3=A1r?= , "Andrew F. Davis" , Linux PM mailing list , linux-kernel , Discussions about the Letux Kernel , kernel@pyra-handheld.com Content-Transfer-Encoding: 8BIT Message-Id: <7428DD60-FE09-41C4-9DBC-FFDCB9D0B591@goldelico.com> References: To: Liam Breck , Sebastian Reichel X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2298 Lines: 63 Hi Liam and Sebastian, > Am 29.08.2017 um 22:20 schrieb Liam Breck : > > Hi Nikolaus, thanks for the patch... > > On Tue, Aug 29, 2017 at 1:10 PM, H. Nikolaus Schaller wrote: >> Tested on Pyra prototype with bq27421. >> >> Signed-off-by: H. Nikolaus Schaller >> --- >> drivers/power/supply/bq27xxx_battery.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c >> index b6c3120ca5ad..e3c878ef7c7e 100644 >> --- a/drivers/power/supply/bq27xxx_battery.c >> +++ b/drivers/power/supply/bq27xxx_battery.c >> @@ -688,7 +688,7 @@ static struct bq27xxx_dm_reg bq27545_dm_regs[] = { >> #define bq27545_dm_regs 0 >> #endif >> >> -#if 0 /* not yet tested */ >> +#if 1 /* tested on Pyra */ >> static struct bq27xxx_dm_reg bq27421_dm_regs[] = { > > I think we can drop the #if and #else...#endif so it's just the > dm_regs table, as with bq27425. I have fixed that and did take the chance to update my OpenPandora kernel so that I also could test and make the bq27500 working. The biggest hurdle was to find out that I have to change the compatible string to "ti,bq27500-1" to get non-NULL dm_regs... [ 12.765930] bq27xxx_battery_i2c_probe name=bq27500-1-0 [ 12.771392] bq27xxx_battery_i2c_probe call setup [ 12.874816] bq27xxx_battery_setup [ 12.904266] bq27xxx_battery_setup: dm_regs=bf0520e0 [ 12.933380] (NULL device *): hwmon: 'bq27500-1-0' is not a valid name attribute, please fix [ 13.234893] bq27xxx_battery_settings [ 13.238891] bq27xxx-battery 2-0055: invalid battery:energy-full-design-microwatt-hours 14800000 [ 13.312469] bq27xxx_battery_set_config [ 13.407745] bq27xxx_battery_unseal [ 13.455993] bq27xxx_battery_update_dm_block [ 13.460418] bq27xxx-battery 2-0055: update terminate-voltage to 3200 [ 13.694885] bq27xxx_battery_seal Does this look ok for bat: battery { compatible = "simple-battery", "openpandora-battery"; voltage-min-design-microvolt = <3200000>; energy-full-design-microwatt-hours = <14800000>; charge-full-design-microamp-hours = <4000000>; }; ? I will send a patch for enabling both fuel gauges and the omap3-pandora-common.dtsi asap. BR and thanks, Nikolaus