Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751822AbdH3NGv (ORCPT ); Wed, 30 Aug 2017 09:06:51 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:1871 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbdH3NGu (ORCPT ); Wed, 30 Aug 2017 09:06:50 -0400 X-IronPort-AV: E=Sophos;i="5.41,448,1498514400"; d="scan'208";a="235732011" Date: Wed, 30 Aug 2017 15:06:22 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: "Reshetova, Elena" cc: "linux-kernel@vger.kernel.org" , "cocci@systeme.lip6.fr" , Gilles Muller , "nicolas.palix@imag.fr" , "mmarek@suse.com" , "keescook@chromium.org" , "ishkamiel@gmail.com" Subject: RE: [PATCH] Coccinelle: add atomic_as_refcounter script In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B6FF61354@IRSMSX102.ger.corp.intel.com> Message-ID: References: <1504073758-16945-1-git-send-email-elena.reshetova@intel.com> <1504073758-16945-2-git-send-email-elena.reshetova@intel.com> <2236FBA76BA1254E88B949DDB74E612B6FF61354@IRSMSX102.ger.corp.intel.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4394 Lines: 177 On Wed, 30 Aug 2017, Reshetova, Elena wrote: > > > > > On Wed, 30 Aug 2017, Elena Reshetova wrote: > > > > > atomic_as_refcounter.cocci script allows detecting > > > cases when refcount_t type and API should be used > > > instead of atomic_t. > > > > > > Signed-off-by: Elena Reshetova > > > > Acked-by: Julia Lawall > > Thank you very much Julia! What is the correct path to merge this? > I will resend with your acked-by, but what is the tree that should merge it? Marek will take it. If you want to resend, please get rid of the metavariable y in the rule r1. It causes an unused variable warning. julia > > Best Regards, > Elena. > > > > > --- > > > scripts/coccinelle/api/atomic_as_refcounter.cocci | 131 > > ++++++++++++++++++++++ > > > 1 file changed, 131 insertions(+) > > > create mode 100644 scripts/coccinelle/api/atomic_as_refcounter.cocci > > > > > > diff --git a/scripts/coccinelle/api/atomic_as_refcounter.cocci > > b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > new file mode 100644 > > > index 0000000..f83771b > > > --- /dev/null > > > +++ b/scripts/coccinelle/api/atomic_as_refcounter.cocci > > > @@ -0,0 +1,131 @@ > > > +// Check if refcount_t type and API should be used > > > +// instead of atomic_t type when dealing with refcounters > > > +// > > > +// Copyright (c) 2016-2017, Elena Reshetova, Intel Corporation > > > +// > > > +// Confidence: Moderate > > > +// URL: http://coccinelle.lip6.fr/ > > > +// Options: --include-headers --very-quiet > > > + > > > +virtual report > > > + > > > +@r1 exists@ > > > +identifier a, x, y; > > > +position p1, p2; > > > +identifier fname =~ ".*free.*"; > > > +identifier fname2 =~ ".*destroy.*"; > > > +identifier fname3 =~ ".*del.*"; > > > +identifier fname4 =~ ".*queue_work.*"; > > > +identifier fname5 =~ ".*schedule_work.*"; > > > +identifier fname6 =~ ".*call_rcu.*"; > > > + > > > +@@ > > > + > > > +( > > > + atomic_dec_and_test@p1(&(a)->x) > > > +| > > > + atomic_dec_and_lock@p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_lock@p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_test@p1(&(a)->x) > > > +| > > > + atomic64_dec_and_test@p1(&(a)->x) > > > +| > > > + local_dec_and_test@p1(&(a)->x) > > > +) > > > +... > > > +( > > > + fname@p2(a, ...); > > > +| > > > + fname2@p2(...); > > > +| > > > + fname3@p2(...); > > > +| > > > + fname4@p2(...); > > > +| > > > + fname5@p2(...); > > > +| > > > + fname6@p2(...); > > > +) > > > + > > > + > > > +@script:python depends on report@ > > > +p1 << r1.p1; > > > +p2 << r1.p2; > > > +@@ > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > + > > > +@r4 exists@ > > > +identifier a, x, y; > > > +position p1, p2; > > > +identifier fname =~ ".*free.*"; > > > + > > > +@@ > > > + > > > +( > > > + atomic_dec_and_test@p1(&(a)->x) > > > +| > > > + atomic_dec_and_lock@p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_lock@p1(&(a)->x, ...) > > > +| > > > + atomic_long_dec_and_test@p1(&(a)->x) > > > +| > > > + atomic64_dec_and_test@p1(&(a)->x) > > > +| > > > + local_dec_and_test@p1(&(a)->x) > > > +) > > > +... > > > +y=a > > > +... > > > +fname@p2(y, ...); > > > + > > > + > > > +@script:python depends on report@ > > > +p1 << r4.p1; > > > +p2 << r4.p2; > > > +@@ > > > +msg = "atomic_dec_and_test variation before object free at line %s." > > > +coccilib.report.print_report(p1[0], msg % (p2[0].line)) > > > + > > > +@r2 exists@ > > > +identifier a, x; > > > +position p1; > > > +@@ > > > + > > > +( > > > +atomic_add_unless(&(a)->x,-1,1)@p1 > > > +| > > > +atomic_long_add_unless(&(a)->x,-1,1)@p1 > > > +| > > > +atomic64_add_unless(&(a)->x,-1,1)@p1 > > > +) > > > + > > > +@script:python depends on report@ > > > +p1 << r2.p1; > > > +@@ > > > +msg = "atomic_add_unless" > > > +coccilib.report.print_report(p1[0], msg) > > > + > > > +@r3 exists@ > > > +identifier x; > > > +position p1; > > > +@@ > > > + > > > +( > > > +x = atomic_add_return@p1(-1, ...); > > > +| > > > +x = atomic_long_add_return@p1(-1, ...); > > > +| > > > +x = atomic64_add_return@p1(-1, ...); > > > +) > > > + > > > +@script:python depends on report@ > > > +p1 << r3.p1; > > > +@@ > > > +msg = "x = atomic_add_return(-1, ...)" > > > +coccilib.report.print_report(p1[0], msg) > > > + > > > + > > > -- > > > 2.7.4 > > > > > > >