Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751480AbdH3NNq (ORCPT ); Wed, 30 Aug 2017 09:13:46 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:34149 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbdH3NNn (ORCPT ); Wed, 30 Aug 2017 09:13:43 -0400 MIME-Version: 1.0 In-Reply-To: <7f877ee7a2a5eada613fcb7044e761248584922d.1503505752.git.arvind.yadav.cs@gmail.com> References: <7f877ee7a2a5eada613fcb7044e761248584922d.1503505752.git.arvind.yadav.cs@gmail.com> From: Ulf Hansson Date: Wed, 30 Aug 2017 15:13:42 +0200 Message-ID: Subject: Re: [PATCH] mmc: mmci: constify amba_id To: Arvind Yadav Cc: Russell King , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 31 On 23 August 2017 at 18:30, Arvind Yadav wrote: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/mmci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c > index d1ca2f4..f1f54a8 100644 > --- a/drivers/mmc/host/mmci.c > +++ b/drivers/mmc/host/mmci.c > @@ -1904,7 +1904,7 @@ static const struct dev_pm_ops mmci_dev_pm_ops = { > SET_RUNTIME_PM_OPS(mmci_runtime_suspend, mmci_runtime_resume, NULL) > }; > > -static struct amba_id mmci_ids[] = { > +static const struct amba_id mmci_ids[] = { > { > .id = 0x00041180, > .mask = 0xff0fffff, > -- > 2.7.4 >