Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbdH3N0Q (ORCPT ); Wed, 30 Aug 2017 09:26:16 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:36008 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbdH3N0O (ORCPT ); Wed, 30 Aug 2017 09:26:14 -0400 X-Google-Smtp-Source: ADKCNb4NC7ok1LEF1x+Hf9ivXQbld1u7kQv3vlbpyxztjQkVj803ElPTGBOCJD2BdNfnV1mg8KwFbg== From: Himanshu Jha To: patrik.r.jakobsson@gmail.com Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Himanshu Jha Subject: [PATCH] drm/gma500: Remove null check before kfree Date: Wed, 30 Aug 2017 18:55:56 +0530 Message-Id: <1504099556-3887-1-git-send-email-himanshujha199640@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 26 kfree on NULL pointer is a no-op and therefore checking is redundant. Signed-off-by: Himanshu Jha --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c index c52f9ad..a4bb89b 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -1901,10 +1901,8 @@ cdv_intel_dp_destroy(struct drm_connector *connector) if (is_edp(gma_encoder)) { /* cdv_intel_panel_destroy_backlight(connector->dev); */ - if (intel_dp->panel_fixed_mode) { - kfree(intel_dp->panel_fixed_mode); - intel_dp->panel_fixed_mode = NULL; - } + kfree(intel_dp->panel_fixed_mode); + intel_dp->panel_fixed_mode = NULL; } i2c_del_adapter(&intel_dp->adapter); drm_connector_unregister(connector); -- 2.7.4