Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646AbdH3OFX (ORCPT ); Wed, 30 Aug 2017 10:05:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:16977 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbdH3OFV (ORCPT ); Wed, 30 Aug 2017 10:05:21 -0400 Date: Wed, 30 Aug 2017 17:04:56 +0300 From: Dan Carpenter To: Shaohua Li , linux-block@vger.kernel.org, Jens Axboe Cc: Tejun Heo , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org Subject: [PATCH] kernfs: checking for IS_ERR() instead of NULL Message-ID: <20170830140456.7n6sfogqb7mvjmrm@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 21 The kernfs_get_inode() returns NULL on error, it never returns error pointers. Fixes: aa8188253474 ("kernfs: add exportfs operations") Signed-off-by: Dan Carpenter diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index 7c452f4d83e9..95a7c88baed9 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/mount.c @@ -99,8 +99,8 @@ static struct inode *kernfs_fh_get_inode(struct super_block *sb, return ERR_PTR(-ESTALE); inode = kernfs_get_inode(sb, kn); kernfs_put(kn); - if (IS_ERR(inode)) - return ERR_CAST(inode); + if (!inode) + return ERR_PTR(-ESTALE); if (generation && inode->i_generation != generation) { /* we didn't find the right inode.. */