Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbdH3OYe (ORCPT ); Wed, 30 Aug 2017 10:24:34 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:33478 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbdH3OYc (ORCPT ); Wed, 30 Aug 2017 10:24:32 -0400 X-Google-Smtp-Source: ADKCNb6LUVFA88UXlqPAlwAwY0DWNlE6cbnRZhHzBqImrGCW5UFEX80fSHLbEbDW+svGeImc2PsCAg== Subject: Re: [RFC] block: deprecate choosing elevator via boot param To: Oleksandr Natalenko , linux-block@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <20170814092712.14062-1-oleksandr@redhat.com> From: Jens Axboe Message-ID: <3efb4cb6-a545-9e1e-8c6e-c2faee7dd8f4@kernel.dk> Date: Wed, 30 Aug 2017 08:24:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170814092712.14062-1-oleksandr@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 20 On 08/14/2017 03:27 AM, Oleksandr Natalenko wrote: > Setting I/O scheduler via kernel command line is not flexible enough > anymore. Different schedulers might be desirable for different types > of devices (SSDs and HDDs, for instance). Moreover, setting elevator > while using blk-mq framework does not work in this way already. > > This commit enables warning if user specifies "elevator" boot param. > Removing this option at all might be considered in some future. Not a huge fan of doing it like this, it'll just add a bunch of noise to the dmesg output that people will ignore. It doesn't bring us closer to being able to remove the option. I think we should just let it die over time. This will happen naturally since the blk-mq scheduling framework does not support it. Once we have everything converted, the option will end up doing nothing. Then we can eventually kill it. -- Jens Axboe