Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751519AbdH3Osp (ORCPT ); Wed, 30 Aug 2017 10:48:45 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:44673 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdH3Oso (ORCPT ); Wed, 30 Aug 2017 10:48:44 -0400 Date: Wed, 30 Aug 2017 16:48:43 +0200 From: Maxime Ripard To: Stefan =?iso-8859-1?Q?Br=FCns?= Cc: linux-sunxi@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring Subject: Re: [RESEND PATCH 2/2] arm64: allwinner: pine64: Enable spi0/spi1 Message-ID: <20170830144843.zyqmf3awivzfqtbf@flea.lan> References: <20170829202652.5476-1-stefan.bruens@rwth-aachen.de> <20170829202652.5476-3-stefan.bruens@rwth-aachen.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yn525shlj5e7alby" Content-Disposition: inline In-Reply-To: <20170829202652.5476-3-stefan.bruens@rwth-aachen.de> User-Agent: NeoMutt/20170714 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2466 Lines: 72 --yn525shlj5e7alby Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Stefan, On Tue, Aug 29, 2017 at 10:26:52PM +0200, Stefan Br=FCns wrote: > The two spi channels/controllers are available on the PI-2 resp. Euler > connector, enable both. Contrary to the Pi, the A64 SOC only supports > one chip select, so the second chipselect is not available (though > it can be emulated using gpio chipselect). >=20 > Signed-off-by: Stefan Br=FCns > --- > arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/a= rm64/boot/dts/allwinner/sun50i-a64-pine64.dts > index 827168bc22ed..f25274e8b3e0 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts > @@ -124,6 +124,14 @@ > status =3D "okay"; > }; > =20 > +&spi0 { > + status =3D "okay"; > +}; > + > +&spi1 { > + status =3D "okay"; > +}; Anything on the Euler or PI connector is muxable to some other function. We cannot enforce a default, since we can't know for sure that all our users will use it that way (even though the majority probably will). This is why you also have those nodes populated but disabled for the uart for example in the pine64 DTS. But in our case, there's not much to populate :) Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --yn525shlj5e7alby Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZptBLAAoJEBx+YmzsjxAgq9QP/3KSG9lA8aBmOsSnh4Oaw0rH /rKp+IBc8kz8SEzuWjmltvUID6gJpQdKgxvmjfEnIA3H0P71sLcr2Ik2xzwz5qkO LKYI5ie1PBexfLaOAyv/prZqhQG32rDPShp78zMsNImBYFhyzWIL5dUDbQ8ALp53 vpflIX94u6WuC5RBc3tUsJG/w710PlW13OoRZfn2LyspxCK8QuYQTa5E0KTQzwa5 75QVo97Ipm1MJFuBr5oWSvVEXgmlyx9S2c6Bcy4e3L4OfXA3jDIDjc8XGdlbY3zi VFMHENgwEZ5yOoO6AOk8fkq47kgBnHRNCOcaGxoHsESNvA1xMR1WhU49uYObfjuv 0r/Hy8b+WCboygujUAREsuYWJ5jmtuyA6LnTzfqzCVqzV/t0oI1aNtUm1MWoa2lk DI4HJ+K6S3/AMIHuGSLnJW6RQJbifaYM/KZisUKxgHbxiV7r5EBPGzfgNoqxwGXv l99G+jiY0o06bfjFSvMAZSEIPPr2Pe4Cwc1bw33KMzQlukA4MuF+g4Ox+crlqPDI JHrXoN7dNGopXlg1rvZa72YmOLVPVNlG+RzEbuSj1He7oLDUOmt85O0Vhs6pOKGG sgYDtMPOdMazbOD+arg8Tnzf4mJaXDcmmVJ0pUfdQEcQMgQSIf1fp4Rw3X9PYL4c anYaMz2XMEMMxsmjb7TR =0sKt -----END PGP SIGNATURE----- --yn525shlj5e7alby--