Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdH3O5F (ORCPT ); Wed, 30 Aug 2017 10:57:05 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:45896 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdH3O5D (ORCPT ); Wed, 30 Aug 2017 10:57:03 -0400 Subject: Re: [PATCH v3 49/59] KVM: arm/arm64: GICv4: Propagate VLPI properties at map time To: Christoffer Dall Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Christoffer Dall , Thomas Gleixner , Jason Cooper , Eric Auger , Shanker Donthineni , Mark Rutland , Shameerali Kolothum Thodi References: <20170731172637.29355-1-marc.zyngier@arm.com> <20170731172637.29355-50-marc.zyngier@arm.com> <20170828181841.GJ24649@cbox> From: Marc Zyngier Organization: ARM Ltd Message-ID: <60012f9d-7eb9-e8f4-a2c4-82e00ff52c0c@arm.com> Date: Wed, 30 Aug 2017 15:56:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170828181841.GJ24649@cbox> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 33 On 28/08/17 19:18, Christoffer Dall wrote: > On Mon, Jul 31, 2017 at 06:26:27PM +0100, Marc Zyngier wrote: >> When the VLPI gets mapped, it must inherit the configuration of >> LPI configured at the vITS level. FOr that purpose, let's make > > *the LPI > *For that Will fix, thanks. > >> update_lpi_config globally available and call it just after >> having performed the VLPI map operation. >> > > I assume this means that the GIC compares the priorities of virtual > interrupts in the LRs with the priorities of the pending VLPIs and > figures out what to signal first? I couldn't find anywhere in the spec > where this is explicitly stated. There is this mention in IHI0069D, 5.4 (Virtual LPI support): "The Redistributor associated with the PE on which the vPE is scheduled determines the highest priority pending vLPI, and forwards this to the virtual CPU interface of the vPE. This vLPI and the interrupts in the List register are then prioritized together to determine the highest priority pending virtual interrupt for the vPE." Thanks, M. -- Jazz is not dead. It just smells funny...