Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751485AbdH3PLI (ORCPT ); Wed, 30 Aug 2017 11:11:08 -0400 Received: from mail-pg0-f54.google.com ([74.125.83.54]:36799 "EHLO mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdH3PLH (ORCPT ); Wed, 30 Aug 2017 11:11:07 -0400 Date: Wed, 30 Aug 2017 08:11:01 -0700 From: Stephen Hemminger To: "Martin K. Petersen" Cc: Long Li , linux-scsi@vger.kernel.org, Haiyang Zhang , "James E . J . Bottomley" , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org Subject: Re: [PATCH] storvsc: fix memory leak on ring buffer busy Message-ID: <20170830081101.5307095d@xeon-e3> In-Reply-To: References: <20170829004359.28526-1-longli@exchange.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 663 Lines: 19 On Tue, 29 Aug 2017 21:31:11 -0400 "Martin K. Petersen" wrote: > Long, > > > When storvsc is sending I/O to Hyper-v, it may allocate a bigger > > buffer descriptor for large data payload that can't fit into a > > pre-allocated buffer descriptor. This bigger buffer is freed on return > > path. > > > > If I/O request to Hyper-v fails due to ring buffer busy, the storvsc > > allocated buffer descriptor should also be freed. > > Which kernel version is this patch aimed at? > Looks like this an old issue. Probably should add Fixes: be0cf6ca301c ("scsi: storvsc: Set the tablesize based on the information given by the host")