Subject: Re: [RESEND PATCH 2/3] regulator: Add support for stm32-vrefbuf
To: Mark Brown <broonie@kernel.org>
CC: <lgirdwood@gmail.com>, <robh+dt@kernel.org>, <alexandre.torgue@st.com>,
        <mark.rutland@arm.com>, <mcoquelin.stm32@gmail.com>,
        <linux@armlinux.org.uk>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <1503925133-30722-1-git-send-email-fabrice.gasnier@st.com>
 <1503925133-30722-3-git-send-email-fabrice.gasnier@st.com>
 <20170829185719.h5fxvzmxbysyxwml@sirena.org.uk>
 <fd883990-cc87-f8cb-ebe7-5c4c4e51d6f6@st.com>
 <20170830150249.5sofmjz3n2skzucq@sirena.org.uk>
From: Fabrice Gasnier <fabrice.gasnier@st.com>
Message-ID: <8777c604-e16c-4359-095d-b3bd6efab5e0@st.com>
Date: Wed, 30 Aug 2017 17:23:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170830150249.5sofmjz3n2skzucq@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 869
Lines: 28


On 08/30/2017 05:02 PM, Mark Brown wrote:
> On Wed, Aug 30, 2017 at 11:11:24AM +0200, Fabrice Gasnier wrote:
>> On 08/29/2017 08:57 PM, Mark Brown wrote:
>>> On Mon, Aug 28, 2017 at 02:58:52PM +0200, Fabrice Gasnier wrote:
> 
>>>> +static int __init stm32_vrefbuf_init(void)
>>>> +{
>>>> +	return platform_driver_register(&stm32_vrefbuf_driver);
>>>> +}
>>>> +subsys_initcall(stm32_vrefbuf_init);
> 
>>> Why is this at subsys_initcall()?
> 
>> Several consumers depend on it when it's being used, among which: STM32
>> internal ADC and DAC, but also external components. Purpose is to ensure
>> it's ready before these drivers gets probed, instead of being deferred.
>> Is it ok to keep it ?
> 
> No, that's not OK - just let deferred probe handle it.  The same thing
> applies to all regulator usage.
> 
Hi Mark,
Ok, I'll update this in v2 as well.

Thanks,
Fabrice