Date: Wed, 30 Aug 2017 08:42:04 -0700
From: Sinclair Yeh <syeh@vmware.com>
To: Thomas Hellstrom <thellstrom@vmware.com>,
        Arvind Yadav <arvind.yadav.cs@gmail.com>, airlied@linux.ie,
        linux-graphics-maintainer@vmware.com, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops
Message-ID: <20170830154203.GA12100@promb-2n-dhcp227.eng.vmware.com>
References: <63ab6910a20e486c69cf768b6d1bf8c8bc60149b.1504071891.git.arvind.yadav.cs@gmail.com>
 <5901b4a5-5eef-393f-7d18-704c037708c6@vmware.com>
 <20170830083024.fokqszud2euwg476@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170830083024.fokqszud2euwg476@phenom.ffwll.local>
User-Agent: Mutt/1.8.2 (2017-04-18)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2017 15:42:13.3780 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3286
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1461
Lines: 33


On Wed, Aug 30, 2017 at 10:30:24AM +0200, Daniel Vetter wrote:
> On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote:
> > On 08/30/2017 07:47 AM, Arvind Yadav wrote:
> > > vmw_fence_ops are not supposed to change at runtime. Functions
> > > "dma_fence_init" working with const vmw_fence_ops provided
> > > by <linux/dma-fence.h>. So mark the non-const structs as const.
> > > 
> > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> > > ---
> > >   drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > index b8bc5bc..abc5f03 100644
> > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> > > @@ -225,7 +225,7 @@ static long vmw_fence_wait(struct dma_fence *f, bool intr, signed long timeout)
> > >   	return ret;
> > >   }
> > > -static struct dma_fence_ops vmw_fence_ops = {
> > > +static const struct dma_fence_ops vmw_fence_ops = {
> > >   	.get_driver_name = vmw_fence_get_driver_name,
> > >   	.get_timeline_name = vmw_fence_get_timeline_name,
> > >   	.enable_signaling = vmw_fence_enable_signaling,
> > 
> > Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> 
> Does this mean you'll merge it, or does this mean you'll expect someone
> else to merge this?

Yes, we have this queued and will go out in the next pull request.