Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbdH3QTK (ORCPT ); Wed, 30 Aug 2017 12:19:10 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:35057 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbdH3QTD (ORCPT ); Wed, 30 Aug 2017 12:19:03 -0400 MIME-Version: 1.0 X-Originating-IP: [90.77.100.34] In-Reply-To: <20170829084831.hsdok3ksi7anxzuc@ninjato> References: <20170615185418.13980-1-javier@dowhile0.org> <20170731153009.xkjknygpmckv2pfp@ninjato> <20170828160121.gu4wf7jqu4ditksc@ninjato> <20170829084831.hsdok3ksi7anxzuc@ninjato> From: Javier Martinez Canillas Date: Wed, 30 Aug 2017 18:19:02 +0200 Message-ID: Subject: Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table To: Wolfram Sang Cc: Linux Kernel , Rob Herring , Florian Larysch , David Lechner , Rob Herring , Andy Shevchenko , Catalin Marinas , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Simon Horman , Michal Simek , Dinh Nguyen , Russell King , Will Deacon , "devicetree@vger.kernel.org" , Sekhar Nori , Scott Wood , Benjamin Herrenschmidt , Joachim Eastwood , Mark Rutland , "linux-arm-kernel@lists.infradead.org" , Masahiro Yamada , Michael Ellerman , Santosh Shilimkar , Linux-Renesas , Paul Mackerras , Magnus Damm , linuxppc-dev , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Linux I2C Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2683 Lines: 77 Hello Wolfram, On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang wrote: > >> I don't have a DT based system at hand now, but I'll test it again and >> let you know probably tomorrow. > > I will try again today, too. Thanks! > Ok, I had some time to do some tests again. I used an ARM Chromebook (Exynos Peach Pi) that has an I2C touchpad (Atmel maXTouch). Tested the following cases: 1) Driver without OF device ID table (only a I2C table with a "maxtouch" entry) and DTS defining a device node with a "atmel,maxtouch" compatible string. This is the case without any of the patches in this series. $ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch alias: i2c:maxtouch $ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent OF_COMPATIBLE_0=atmel,maxtouch MODALIAS=i2c:maxtouch 2) Driver without OF device ID table (only a I2C table with a "maxtouch" entry) and DTS defining a device node with a "atmel,maxtouch", "generic,maxtouch" compatible string. This is the case when platform maintainers merge the DTS patches without the driver patch. $ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch alias: i2c:maxtouch $ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent OF_COMPATIBLE_0=atmel,maxtouch OF_COMPATIBLE_1=generic,maxtouch MODALIAS=i2c:maxtouch 3) Driver with an OF device ID table (with a "generic,maxtouch" entry) and DTS defining a device node with a "atmel,maxtouch" compatible string. This is the case when the driver patch is merged without the DTS patches. $ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch alias: of:N*T*Cgeneric,maxtouchC* alias: of:N*T*Cgeneric,maxtouch alias: i2c:maxtouch $ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent OF_COMPATIBLE_0=atmel,maxtouch MODALIAS=i2c:maxtouch 4) Driver with an OF device ID table (with a "generic,maxtouch" entry) and DTS defining a device node with a "atmel,maxtouch", "generic,maxtouch" compatible string. This is the case when both the DTS and driver patches are merged. $ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch alias: of:N*T*Cgeneric,maxtouchC* alias: of:N*T*Cgeneric,maxtouch alias: i2c:maxtouch $ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent OF_COMPATIBLE_0=atmel,maxtouch OF_COMPATIBLE_1=generic,maxtouch MODALIAS=i2c:maxtouch For all cases module autoload, driver probe and evtest worked for me. You said that (3) doesn't work but I don't understand why is failing for you. Probably I'm missing something. Best regards, Javier