Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966AbdH3Q0s (ORCPT ); Wed, 30 Aug 2017 12:26:48 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34703 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbdH3Q0q (ORCPT ); Wed, 30 Aug 2017 12:26:46 -0400 Date: Wed, 30 Aug 2017 09:26:43 -0700 From: Brian Norris To: Thierry Reding Cc: Derek Basehore , linux-kernel@vger.kernel.org, jingoohan1@gmail.com, lee.jones@linaro.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v2] pwm_bl: Fix overflow condition Message-ID: <20170830162641.GA43114@google.com> References: <20170829203434.6826-1-dbasehore@chromium.org> <20170830142741.GD1361@ulmo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830142741.GD1361@ulmo> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 438 Lines: 14 On Wed, Aug 30, 2017 at 04:27:41PM +0200, Thierry Reding wrote: > I'm still confused by the brightness-levels-scale comment in the other > thread, I believe Derek was accidentally referring to a change that's only in our downstream tree. > but this looks like a good fix for a potential overflow so: Right, it's still an applicable overflow without our downstream changes. Brian > Acked-by: Thierry Reding