Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752327AbdH3RP0 (ORCPT ); Wed, 30 Aug 2017 13:15:26 -0400 Received: from mail-bl2nam02on0053.outbound.protection.outlook.com ([104.47.38.53]:46080 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752046AbdH3RPX (ORCPT ); Wed, 30 Aug 2017 13:15:23 -0400 From: "Madhani, Himanshu" To: Johannes Thumshirn CC: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Dept-Eng QLA2xxx Upstream Subject: Re: [PATCH] qla2xxx: add missing includes for qla_isr Thread-Topic: [PATCH] qla2xxx: add missing includes for qla_isr Thread-Index: AQHTIZGqj+v1WDVtg0KqhK2HaQj2rKKdI/iA Date: Wed, 30 Aug 2017 17:15:20 +0000 Message-ID: References: <20170830131231.7934-1-jthumshirn@suse.de> In-Reply-To: <20170830131231.7934-1-jthumshirn@suse.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Himanshu.Madhani@cavium.com; x-originating-ip: [173.186.134.106] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BN6PR07MB2818;6:JlZG7HYSE13zWqIKJaz3LdTW7c2FzRFzB7Pt/RyeMq+jIcLlqZsTdvr8pa1+iH5tqy029/0/k2tQvSWGrnim0i4702mRfC6KsTaFfLDTrVVFqF2GWWS9arLgPskrkmFuQ+8DycV7hOVyaCeU4fmUQf/RrcUJ4rdQqQdjEbL3Nts60EeJdXW9HW23mJGdbNgjmAdeYRLzA+pM6HfLW6fOgpLltiOrgqmjwUlUDpmj3vbSga1EgtZElPNh2zH2TqiiJ8m7a3OaTcJ/UZYat/AL44pZXJuY6B5eBYACFZvlSOWVBS/zFohuaoz1kSotvxPtZ5LjUw816hn/dwnxChDEnA==;5:kBdCmPlUDJyGFVy7rRWlX92/QF2uw6YyOUEPIOCbLmcG7pZGZpYTBTReIOzBZJ2w6328DaCUFP9Nd9PtiXBOq6XevJ/NsraeIylRCuDw9FuOex3h8MdJhq/9OpWEUzaa+xfM0AF1lV2szyFOy0iJqw==;24:x62mv4XnWLk6a3ZUJJIKOBmYiMX5NfJWq+savGiPrfzgya8yqYFohD4dVij9KPO6tIMfn8l1PU3yasSGhUjbQq4KoecGwNfE+tBXOd2fwUo=;7:DAUi5yQ23Kgc658j2b8qRp7zZYMhlx3AixjYZCO6D4Ot1Ff/utCj7vziWAuXvOIfXRlD3WmvkgZ5gzkcWazjNxdA96TdBg9nfOpzE8RYVRAaC/x0l8xSuuatEYs6e+kRl+nLFUS58NUlpzksmWdFMpv0ckuykPNmuS/kjKk8JwTzKaJo7PBNrUUUO+F8L3E7zAoTidRK4vGPiwgXBH+SRgw6W1WF2WROzK6DrUeylrA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: cc4eeae1-d9b3-4fa7-aece-08d4efcab14b x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BN6PR07MB2818; x-ms-traffictypediagnostic: BN6PR07MB2818: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BN6PR07MB2818;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BN6PR07MB2818; x-forefront-prvs: 041517DFAB x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(189002)(199003)(377454003)(24454002)(102836003)(110136004)(101416001)(53936002)(6512007)(6116002)(6246003)(54906002)(107886003)(189998001)(6486002)(3280700002)(4326008)(6506006)(77096006)(3846002)(33656002)(2906002)(106356001)(86362001)(6436002)(68736007)(229853002)(7736002)(25786009)(14454004)(83716003)(478600001)(105586002)(8676002)(2900100001)(53546010)(305945005)(2950100002)(36756003)(81156014)(81166006)(82746002)(66066001)(97736004)(6916009)(3660700001)(99286003)(5660300001)(8936002)(72206003)(76176999)(50986999)(54356999);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR07MB2818;H:BN6PR07MB3444.namprd07.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <5025FFD3E9CF49408A63FFB4F582CEF9@namprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2017 17:15:20.1010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB2818 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7UHFUQd024317 Content-Length: 1326 Lines: 40 > On Aug 30, 2017, at 6:12 AM, Johannes Thumshirn wrote: > > Since commit 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") > we make use of 'struct nvmefc_fcp_req' in qla24xx_nvme_iocb_entry() without > including linux/nvme-fc-driver.h where it is defined. > > Add linux/nvme-fc-driver.h (and scsi/fc/fc_fs.h as nvme-fc-driver.h needs > the definition of 'struct fc_ba_rjt' from scsi/fc/fc_fs.h) to the header > files included by qla_isr.c. > > Fixes: 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") > Signed-off-by: Johannes Thumshirn > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 7b3b702ef622..b57cbe4ec32b 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -14,6 +14,8 @@ > #include > #include > #include > +#include > +#include > > static void qla2x00_mbx_completion(scsi_qla_host_t *, uint16_t); > static void qla2x00_status_entry(scsi_qla_host_t *, struct rsp_que *, void *); > -- > 2.12.3 > Good catch. Acked-by: Himanshu Madhani Thanks, - Himanshu