Date: Wed, 30 Aug 2017 19:54:06 +0200
From: Borislav Petkov <bp@alien8.de>
To: Jan Glauber <jglauber@cavium.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Suzuki K Poulose <Suzuki.Poulose@arm.com>,
        David Daney <david.daney@cavium.com>
Subject: Re: [RFC PATCH v9 1/7] edac: thunderx: Remove suspend/resume support
Message-ID: <20170830175406.ygmathi3b5orzyqy@pd.tnic>
References: <20170829131238.4988-1-jglauber@cavium.com>
 <20170829131238.4988-2-jglauber@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170829131238.4988-2-jglauber@cavium.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1298
Lines: 35

On Tue, Aug 29, 2017 at 03:12:32PM +0200, Jan Glauber wrote:
> The memory controller on ThunderX/OcteonTX systems does not
> support power management. Therefore remove the suspend/resume
> callbacks.
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>
> ---
>  drivers/edac/thunderx_edac.c | 21 ---------------------
>  1 file changed, 21 deletions(-)

Just when I thought I'd pick that one up now because it is removing
stuff:

drivers/edac/thunderx_edac.c:817:14: error: ‘thunderx_lmc_suspend’ undeclared here (not in a function)
  .suspend  = thunderx_lmc_suspend,
              ^~~~~~~~~~~~~~~~~~~~
drivers/edac/thunderx_edac.c:818:14: error: ‘thunderx_lmc_resume’ undeclared here (not in a function)
  .resume   = thunderx_lmc_resume,
              ^~~~~~~~~~~~~~~~~~~
scripts/Makefile.build:308: recipe for target 'drivers/edac/thunderx_edac.o' failed
make[1]: *** [drivers/edac/thunderx_edac.o] Error 1
make[1]: *** Waiting for unfinished jobs....
Makefile:1682: recipe for target 'drivers/edac/' failed
make: *** [drivers/edac/] Error 2

Please make sure you build and test every patch before submitting.
You're lucky I can at least build arm64 on my x86 workstation. :-)

Thx.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.