Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751001AbdH3Sxs (ORCPT ); Wed, 30 Aug 2017 14:53:48 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:45431 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdH3Sxr (ORCPT ); Wed, 30 Aug 2017 14:53:47 -0400 Date: Wed, 30 Aug 2017 20:53:46 +0200 From: Andrew Lunn To: Corentin Labbe Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] net: mdio-mux: fix unbalanced put_device Message-ID: <20170830185346.GJ22289@lunn.ch> References: <20170830174651.30325-1-clabbe.montjoie@gmail.com> <20170830174651.30325-6-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170830174651.30325-6-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 244 Lines: 13 > err_pb_kz: > /* balance the reference of_mdio_find_bus() took */ Hi Corentin This comment should probably be updated as well. > - if (!mux_bus) > - put_device(&parent_bus->dev); > + put_device(&parent_bus->dev); Thanks Andrew