Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750998AbdH3TSe (ORCPT ); Wed, 30 Aug 2017 15:18:34 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:37627 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdH3TSb (ORCPT ); Wed, 30 Aug 2017 15:18:31 -0400 MIME-Version: 1.0 In-Reply-To: <1503315792-14837-6-git-send-email-bhumirks@gmail.com> References: <1503315792-14837-1-git-send-email-bhumirks@gmail.com> <1503315792-14837-6-git-send-email-bhumirks@gmail.com> From: Andy Shevchenko Date: Wed, 30 Aug 2017 22:18:29 +0300 Message-ID: Subject: Re: [PATCH 5/6] platform/x86: make device_attribute const To: Bhumika Goyal Cc: Julia Lawall , "Rafael J. Wysocki" , Len Brown , Josef Bacik , Jiri Kosina , Benjamin Tissoires , manish.chopra@cavium.com, rahul.verma@cavium.com, Dept-GELinuxNICDev@cavium.com, harish.patil@cavium.com, cascardo@holoscopio.com, don@syst.com.br, "dvhart@infradead.org" , Andy Shevchenko , Sebastian Reichel , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-block@vger.kernel.org, nbd-general@lists.sourceforge.net, linux-input , netdev , Platform Driver , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3025 Lines: 77 On Mon, Aug 21, 2017 at 2:43 PM, Bhumika Goyal wrote: > Make these const as they are only passed as an argument to the > function device_create_file and device_remove_file and the corresponding > arguments are of type const. > Done using Coccinelle > Split on per driver basis. > Signed-off-by: Bhumika Goyal > --- > drivers/platform/x86/classmate-laptop.c | 6 +++--- > drivers/platform/x86/intel-rst.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index 55cf10b..d3715e2 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -254,7 +254,7 @@ static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev, > return strnlen(buf, count); > } > > -static struct device_attribute cmpc_accel_sensitivity_attr_v4 = { > +static const struct device_attribute cmpc_accel_sensitivity_attr_v4 = { > .attr = { .name = "sensitivity", .mode = 0660 }, > .show = cmpc_accel_sensitivity_show_v4, > .store = cmpc_accel_sensitivity_store_v4 > @@ -303,7 +303,7 @@ static ssize_t cmpc_accel_g_select_store_v4(struct device *dev, > return strnlen(buf, count); > } > > -static struct device_attribute cmpc_accel_g_select_attr_v4 = { > +static const struct device_attribute cmpc_accel_g_select_attr_v4 = { > .attr = { .name = "g_select", .mode = 0660 }, > .show = cmpc_accel_g_select_show_v4, > .store = cmpc_accel_g_select_store_v4 > @@ -599,7 +599,7 @@ static ssize_t cmpc_accel_sensitivity_store(struct device *dev, > return strnlen(buf, count); > } > > -static struct device_attribute cmpc_accel_sensitivity_attr = { > +static const struct device_attribute cmpc_accel_sensitivity_attr = { > .attr = { .name = "sensitivity", .mode = 0660 }, > .show = cmpc_accel_sensitivity_show, > .store = cmpc_accel_sensitivity_store > diff --git a/drivers/platform/x86/intel-rst.c b/drivers/platform/x86/intel-rst.c > index 7344d84..760a9bf 100644 > --- a/drivers/platform/x86/intel-rst.c > +++ b/drivers/platform/x86/intel-rst.c > @@ -65,7 +65,7 @@ static ssize_t irst_store_wakeup_events(struct device *dev, > return count; > } > > -static struct device_attribute irst_wakeup_attr = { > +static const struct device_attribute irst_wakeup_attr = { > .attr = { .name = "wakeup_events", .mode = 0600 }, > .show = irst_show_wakeup_events, > .store = irst_store_wakeup_events > @@ -111,7 +111,7 @@ static ssize_t irst_store_wakeup_time(struct device *dev, > return count; > } > > -static struct device_attribute irst_timeout_attr = { > +static const struct device_attribute irst_timeout_attr = { > .attr = { .name = "wakeup_time", .mode = 0600 }, > .show = irst_show_wakeup_time, > .store = irst_store_wakeup_time > -- > 1.9.1 > -- With Best Regards, Andy Shevchenko