Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbdH3Tqk (ORCPT ); Wed, 30 Aug 2017 15:46:40 -0400 Received: from mail-ua0-f171.google.com ([209.85.217.171]:37450 "EHLO mail-ua0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdH3Tqj (ORCPT ); Wed, 30 Aug 2017 15:46:39 -0400 MIME-Version: 1.0 In-Reply-To: <20170830060743.GC3035@kroah.com> References: <20170830004702.120371-1-sherryy@android.com> <20170830004702.120371-2-sherryy@android.com> <20170830060743.GC3035@kroah.com> From: Sherry Yang Date: Wed, 30 Aug 2017 12:46:38 -0700 Message-ID: Subject: Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, "open list:ANDROID DRIVERS" , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Riley Andrews , Martijn Coenen , Todd Kjos Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1591 Lines: 42 On Tue, Aug 29, 2017 at 11:07 PM, Greg Kroah-Hartman wrote: > On Tue, Aug 29, 2017 at 05:46:57PM -0700, Sherry Yang wrote: >> Use helper functions buffer_next and buffer_prev instead >> of list_entry to get the next and previous buffers. >> >> Signed-off-by: Sherry Yang >> --- >> drivers/android/binder_alloc.c | 24 +++++++++++++++--------- >> 1 file changed, 15 insertions(+), 9 deletions(-) > > What changed from the previous version? This specific patch didn't change. The change is only in [patch v3 3/6] (crash fix) and in [patch v3 6/6] (new patch that add stats). > Always put the changes below the --- line. Like the documentation says > to do so. Do you mean I should use --annotate to git send-email to specify what has changed across versions for each patch? I used --compose and put what changed from v2 to v3 in the introductory message [patch 0/6]. > Also, don't I already have these patches in my tree? Do you want me to > revert the existing ones and use the new ones, or what about a fixup > patch for any differences? I got a message saying a test failed on [patch 3/5]. I resubmitted the entire thread because I wasn't sure if you would drop the failing patch set. If the entire failing patch set is dropped, then v3 can be used as a replacement. If you prefer a fixup patch, I can post another patch set (the crash fix and the new patch) on top of what you already applied, but it might be easier to do what's described in the previous paragraph (drop v2 and apply v3). Sherry Yang > confused, > > greg k-h