Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751412AbdH3UFC (ORCPT ); Wed, 30 Aug 2017 16:05:02 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36412 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbdH3UFA (ORCPT ); Wed, 30 Aug 2017 16:05:00 -0400 Date: Wed, 30 Aug 2017 22:04:58 +0200 From: Christoffer Dall To: Marc Zyngier Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Christoffer Dall , Thomas Gleixner , Jason Cooper , Eric Auger , Shanker Donthineni , Mark Rutland , Shameerali Kolothum Thodi Subject: Re: [PATCH v3 44/59] KVM: arm/arm64: GICv4: Handle MOVI applied to a VLPI Message-ID: <20170830200458.GK24522@cbox> References: <20170731172637.29355-1-marc.zyngier@arm.com> <20170731172637.29355-45-marc.zyngier@arm.com> <20170828181817.GE24649@cbox> <954a7441-c91e-5d1b-98b7-2978291c5259@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <954a7441-c91e-5d1b-98b7-2978291c5259@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2109 Lines: 53 On Wed, Aug 30, 2017 at 03:08:01PM +0100, Marc Zyngier wrote: > On 28/08/17 19:18, Christoffer Dall wrote: > > On Mon, Jul 31, 2017 at 06:26:22PM +0100, Marc Zyngier wrote: > >> When the guest issues a MOVI, we need to tell the physical ITS > >> that we're now targetting a new vcpu. This is done by extracting > >> the current mapping, updating the target, and reapplying the > >> mapping. The core ITS code should do the right thing. > >> > >> Signed-off-by: Marc Zyngier > >> --- > >> virt/kvm/arm/vgic/vgic-its.c | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c > >> index 79bac93d3e7d..aaad577ce328 100644 > >> --- a/virt/kvm/arm/vgic/vgic-its.c > >> +++ b/virt/kvm/arm/vgic/vgic-its.c > >> @@ -706,6 +706,19 @@ static int vgic_its_cmd_handle_movi(struct kvm *kvm, struct vgic_its *its, > >> ite->irq->target_vcpu = vcpu; > >> spin_unlock(&ite->irq->irq_lock); > >> > >> + if (ite->irq->hw) { > >> + struct its_vlpi_map map; > >> + int ret; > >> + > >> + ret = its_get_vlpi(ite->irq->host_irq, &map); > >> + if (ret) > >> + return ret; > >> + > >> + map.vpe_idx = vcpu->vcpu_id; > >> + > >> + return its_map_vlpi(ite->irq->host_irq, &map); > > > > Since you're not holding the irq_lock across these two calls, would it > > be possible that the forwarding was removed through some other call path > > here, and could you end up passing an invalid host_irq to its_map_vlpi? > I believe we should be OK here, as we hold the ITS mutex during any > command processing, and both the forward/unforward paths take that same > mutex. ok, yes, as long as the only other modifirs are the forward/unforward paths and they hold the mutex, we should be fine. > > On a slightly different note, it looks like the MOVI code could benefit > from using vgic_its_resolve_lpi(), which has been introduce earlier in > this series. Only problem is you'd need to get a handle to the ite as well to change the collection pointer. I suppose you could add another pointer pointer. -Christoffer