Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750975AbdH3UHD (ORCPT ); Wed, 30 Aug 2017 16:07:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:35078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdH3UHC (ORCPT ); Wed, 30 Aug 2017 16:07:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8394D2199E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 30 Aug 2017 15:07:00 -0500 From: Bjorn Helgaas To: Jan Luebbe Cc: Gregory Clement , Andrew Lunn , Thomas Petazzoni , Jason Cooper , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu Message-ID: <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> References: <20170828152517.24506-1-jlu@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828152517.24506-1-jlu@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 22 On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote: > The current MBUS DRAM window calculation fails for 4GB windows because it > overflows. This is fixed in the first patch by using u64 instead of u32 to > store the size. The second excplicitly checks that we don't try to configure a > too large memory window in the pci driver. > > As they don't depend on each other, they could also go in separatly. > > Jan Luebbe (2): > bus: mbus: fix window size calculation for 4GB windows > PCI: mvebu: Check DRAM window size > > drivers/bus/mvebu-mbus.c | 2 +- > drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++----- > include/linux/mbus.h | 4 ++-- > 3 files changed, 25 insertions(+), 8 deletions(-) Since these can be applied separately, I'll let somebody else take care of the drivers/bus/mvebu-mbus.c part. I'll look for an ack from Thomas or Jason before applying the second patch, which touches drivers/pci/host/pci-mvebu.c.