Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751511AbdH3UW5 (ORCPT ); Wed, 30 Aug 2017 16:22:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33156 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbdH3UW4 (ORCPT ); Wed, 30 Aug 2017 16:22:56 -0400 Date: Wed, 30 Aug 2017 23:20:51 +0300 From: Dan Carpenter To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: Sherry Yang , LKML , "open list:ANDROID DRIVERS" , Greg Kroah-Hartman , Riley Andrews , Martijn Coenen , Todd Kjos Subject: Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared with user space Message-ID: <20170830202051.zfqpu7rx6wrhrbex@mwanda> References: <20170830004702.120371-1-sherryy@android.com> <20170830004702.120371-4-sherryy@android.com> <20170830092904.b43bmlveo5g4c6rd@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1824 Lines: 39 On Wed, Aug 30, 2017 at 01:04:31PM -0700, Arve Hj?nnev?g wrote: > On Wed, Aug 30, 2017 at 2:29 AM, Dan Carpenter wrote: > > On Tue, Aug 29, 2017 at 05:46:59PM -0700, Sherry Yang wrote: > >> Binder driver allocates buffer meta data in a region that is mapped > >> in user space. These meta data contain pointers in the kernel. > >> > >> This patch allocates buffer meta data on the kernel heap that is > >> not mapped in user space, and uses a pointer to refer to the data mapped. > >> > >> Also move alloc->buffers initialization from mmap to init since it's > >> now used even when mmap failed or was not called. > >> > >> Signed-off-by: Sherry Yang > >> --- > > > > The difference between v2 and v3 is that we've shifted some > > initialization around to fix the crashing bug that kbuild found. You > > should not that difference here under the --- cut off. > > > >> drivers/android/binder_alloc.c | 146 +++++++++++++++++++------------- > >> drivers/android/binder_alloc.h | 2 +- > >> drivers/android/binder_alloc_selftest.c | 11 ++- > >> 3 files changed, 91 insertions(+), 68 deletions(-) > > > > But really we still need to have some answers or discussion about the > > questions that Greg and I raised. Greg asked if the other Android devs > > had Acked this. Please ping Arve to Ack this. > > > tkjos@google.com replied and ack'ed v2. The changes have been reviewed > on android-review.googlesource.com. Do you want and ack or review tag > included in the patchset or do you want separate ack emails on each > patchset (or on each patch)? Just acking it once is fine. I don't see that email from Todd in my inbox and can't find it on the web archive either... Something must have gone wrong but I don't know what. regards, dan carpenter