Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbdH3VDs (ORCPT ); Wed, 30 Aug 2017 17:03:48 -0400 Received: from mail-qt0-f178.google.com ([209.85.216.178]:37104 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972AbdH3VDq (ORCPT ); Wed, 30 Aug 2017 17:03:46 -0400 X-Google-Smtp-Source: ADKCNb5qZJV19oDWatJnEecSTegV535XRVCxtp9dqWokyOnNvFcpD09tr5f7DCcZhVTbKxb/wvLk73lKCQe47SUt2L8= MIME-Version: 1.0 In-Reply-To: <20170830202051.zfqpu7rx6wrhrbex@mwanda> References: <20170830004702.120371-1-sherryy@android.com> <20170830004702.120371-4-sherryy@android.com> <20170830092904.b43bmlveo5g4c6rd@mwanda> <20170830202051.zfqpu7rx6wrhrbex@mwanda> From: Todd Kjos Date: Wed, 30 Aug 2017 14:03:45 -0700 Message-ID: Subject: Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared with user space To: Dan Carpenter Cc: =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Sherry Yang , LKML , "open list:ANDROID DRIVERS" , Greg Kroah-Hartman , Riley Andrews , Martijn Coenen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7UL3t75005697 Content-Length: 2127 Lines: 45 I just went back through it -- turns out my email bounced back from linux-kernel@vger.kernel.org (reason was "may contain a virus"). Sorry I didn't notice that and resend. On Wed, Aug 30, 2017 at 1:20 PM, Dan Carpenter wrote: > On Wed, Aug 30, 2017 at 01:04:31PM -0700, Arve Hjønnevåg wrote: >> On Wed, Aug 30, 2017 at 2:29 AM, Dan Carpenter wrote: >> > On Tue, Aug 29, 2017 at 05:46:59PM -0700, Sherry Yang wrote: >> >> Binder driver allocates buffer meta data in a region that is mapped >> >> in user space. These meta data contain pointers in the kernel. >> >> >> >> This patch allocates buffer meta data on the kernel heap that is >> >> not mapped in user space, and uses a pointer to refer to the data mapped. >> >> >> >> Also move alloc->buffers initialization from mmap to init since it's >> >> now used even when mmap failed or was not called. >> >> >> >> Signed-off-by: Sherry Yang >> >> --- >> > >> > The difference between v2 and v3 is that we've shifted some >> > initialization around to fix the crashing bug that kbuild found. You >> > should not that difference here under the --- cut off. >> > >> >> drivers/android/binder_alloc.c | 146 +++++++++++++++++++------------- >> >> drivers/android/binder_alloc.h | 2 +- >> >> drivers/android/binder_alloc_selftest.c | 11 ++- >> >> 3 files changed, 91 insertions(+), 68 deletions(-) >> > >> > But really we still need to have some answers or discussion about the >> > questions that Greg and I raised. Greg asked if the other Android devs >> > had Acked this. Please ping Arve to Ack this. >> > >> tkjos@google.com replied and ack'ed v2. The changes have been reviewed >> on android-review.googlesource.com. Do you want and ack or review tag >> included in the patchset or do you want separate ack emails on each >> patchset (or on each patch)? > > Just acking it once is fine. I don't see that email from Todd in my > inbox and can't find it on the web archive either... Something must > have gone wrong but I don't know what. > > regards, > dan carpenter >