Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751285AbdH3VW2 (ORCPT ); Wed, 30 Aug 2017 17:22:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:35987 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbdH3VW1 (ORCPT ); Wed, 30 Aug 2017 17:22:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,450,1498546800"; d="scan'208";a="1189959745" Date: Wed, 30 Aug 2017 14:21:44 -0700 From: Fenghua Yu To: Pavel Tatashin Cc: linux@armlinux.org.uk, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, john.stultz@linaro.org, sboyd@codeaurora.org, pasha.tatashin@oracle.com, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, hpa@zytor.com, douly.fnst@cn.fujitsu.com Subject: Re: [PATCH v6 4/4] x86/tsc: use tsc early Message-ID: <20170830212144.GA48728@linux.intel.com> References: <1504116205-355281-1-git-send-email-pasha.tatashin@oracle.com> <1504116205-355281-5-git-send-email-pasha.tatashin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 323 Lines: 13 On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote: > +static struct cyc2ns_data cyc2ns_early; > +static bool sched_clock_early_enabled; Should these two varaibles be "__initdata"? > +u64 sched_clock_early(void) This function is only called during boot time. Should it be a "__init" function? Thanks. -Fenghua