Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdH3VYj (ORCPT ); Wed, 30 Aug 2017 17:24:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36780 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbdH3VYh (ORCPT ); Wed, 30 Aug 2017 17:24:37 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com DA1445F739 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=alex.williamson@redhat.com Date: Wed, 30 Aug 2017 15:24:36 -0600 From: Alex Williamson To: Arvind Yadav Cc: b.reynal@virtualopensystems.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] vfio: platform: constify amba_id Message-ID: <20170830152436.7a06373a@w520.home> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 21:24:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 846 Lines: 28 On Wed, 23 Aug 2017 22:47:15 +0530 Arvind Yadav wrote: > amba_id are not supposed to change at runtime. All functions > working with const amba_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/vfio/platform/vfio_amba.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c > index 31372fb..62dfbfe 100644 > --- a/drivers/vfio/platform/vfio_amba.c > +++ b/drivers/vfio/platform/vfio_amba.c > @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev) > return -EINVAL; > } > > -static struct amba_id pl330_ids[] = { > +static const struct amba_id pl330_ids[] = { > { 0, 0 }, > }; > Applied to next branch for v4.14. Thanks, Alex