Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbdH3Vdi (ORCPT ); Wed, 30 Aug 2017 17:33:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49961 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbdH3Vdh (ORCPT ); Wed, 30 Aug 2017 17:33:37 -0400 Subject: Re: [PATCH v6 4/4] x86/tsc: use tsc early To: Fenghua Yu Cc: linux@armlinux.org.uk, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, john.stultz@linaro.org, sboyd@codeaurora.org, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, hpa@zytor.com, douly.fnst@cn.fujitsu.com References: <1504116205-355281-1-git-send-email-pasha.tatashin@oracle.com> <1504116205-355281-5-git-send-email-pasha.tatashin@oracle.com> <20170830212144.GA48728@linux.intel.com> From: Pasha Tatashin Message-ID: Date: Wed, 30 Aug 2017 17:32:36 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170830212144.GA48728@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 622 Lines: 26 Hi Fenghua, Thank you for looking at this. Unfortunately I can't mark either of them __init because sched_clock_early() is called from u64 sched_clock_cpu(int cpu) Which is around for the live of the system. Thank you, Pasha On 08/30/2017 05:21 PM, Fenghua Yu wrote: > On Wed, Aug 30, 2017 at 02:12:09PM -0700, Fenghua Yu wrote: >> +static struct cyc2ns_data cyc2ns_early; >> +static bool sched_clock_early_enabled; > > Should these two varaibles be "__initdata"? > >> +u64 sched_clock_early(void) > This function is only called during boot time. Should it > be a "__init" function? > > Thanks. > > -Fenghua >