Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbdH3Vtr (ORCPT ); Wed, 30 Aug 2017 17:49:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44070 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdH3Vtp (ORCPT ); Wed, 30 Aug 2017 17:49:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DC74860B7E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=timur@codeaurora.org Subject: Re: Regression in next with gpiolib To: Tony Lindgren , Linus Walleij , Grygorii Strashko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org References: <20170830214127.GJ6008@atomide.com> From: Timur Tabi Message-ID: <5c672146-2a4c-6da5-85b1-5f2bb2ae5649@codeaurora.org> Date: Wed, 30 Aug 2017 16:49:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170830214127.GJ6008@atomide.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 660 Lines: 15 On 08/30/2017 04:41 PM, Tony Lindgren wrote: > It seems to be that we're now calling request and free on all gpios > before they are properly configured? Yes, that's what my patch does. At the time, it seemed like a good idea -- request the GPIO before touching its hardware. But it appears that the 'request' function of some drivers also re-muxes the GPIO in order to honor the request. The question is whether that's correct behavior. I don't know. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.