Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751589AbdH3WDG (ORCPT ); Wed, 30 Aug 2017 18:03:06 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60844 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbdH3WDE (ORCPT ); Wed, 30 Aug 2017 18:03:04 -0400 Subject: Re: [PATCH 1/2] docs: kernel-doc comments are ASCII To: Jonathan Corbet Cc: "linux-doc@vger.kernel.org" , LKML , linux-media , Mauro Carvalho Chehab References: <54c23e8e-89c0-5cea-0dcc-e938952c5642@infradead.org> <20170830152314.0486fafb@lwn.net> From: Randy Dunlap Message-ID: <3390facf-69ae-ba18-8abe-09b5695a6b31@infradead.org> Date: Wed, 30 Aug 2017 15:02:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170830152314.0486fafb@lwn.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 30 On 08/30/17 14:23, Jonathan Corbet wrote: > On Mon, 28 Aug 2017 16:10:09 -0700 > Randy Dunlap wrote: > >> kernel-doc parsing uses as ASCII codec, so let people know that >> kernel-doc comments should be in ASCII characters only. >> >> WARNING: kernel-doc '../scripts/kernel-doc -rst -enable-lineno ../drivers/media/dvb-core/demux.h' processing failed with: 'ascii' codec can't decode byte 0xe2 in position 6368: ordinal not in range(128) > > So I don't get this error. What kind of system are you running the docs > build on? I would really rather that the docs system could handle modern > text if possible, so it would be better to figure out what's going on > here... I'm OK with that. Source files in general don't need to be ASCII (0-127). I did this patch based on this (private) comment: > Yes, using ASCII should fix the problem. what kind of system? HP laptop. Linux midway.site 4.4.79-18.26-default #1 SMP Thu Aug 10 20:30:05 UTC 2017 (fa5a935) x86_64 x86_64 x86_64 GNU/Linux > sphinx-build --version Sphinx (sphinx-build) 1.3.1 -- ~Randy