Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751521AbdH3WaJ (ORCPT ); Wed, 30 Aug 2017 18:30:09 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35492 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdH3WaI (ORCPT ); Wed, 30 Aug 2017 18:30:08 -0400 Date: Wed, 30 Aug 2017 15:30:07 -0700 (PDT) Message-Id: <20170830.153007.110092081024877123.davem@davemloft.net> To: salil.mehta@huawei.com Cc: yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH net-next] net: hns3: Fixes the wrong IS_ERR check on the returned phydev value From: David Miller In-Reply-To: <20170830110603.12372-1-salil.mehta@huawei.com> References: <20170830110603.12372-1-salil.mehta@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 30 Aug 2017 15:30:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 468 Lines: 13 From: Salil Mehta Date: Wed, 30 Aug 2017 12:06:03 +0100 > This patch removes the wrong check being done for the phy device being > returned by the mdiobus_get_phy() function. This function never returns > the error pointers. > > Fixes: 256727da7395 ("net: hns3: Add MDIO support to HNS3 Ethernet > Driver for hip08 SoC") > Reported-by: Dan Carpenter > Signed-off-by: Salil Mehta Applied.