Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751664AbdH3XQB (ORCPT ); Wed, 30 Aug 2017 19:16:01 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33102 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbdH3XP7 (ORCPT ); Wed, 30 Aug 2017 19:15:59 -0400 Subject: Re: [PATCH 1/2] docs: kernel-doc comments are ASCII From: Randy Dunlap To: Jonathan Corbet , Mauro Carvalho Chehab Cc: "linux-doc@vger.kernel.org" , LKML , linux-media References: <54c23e8e-89c0-5cea-0dcc-e938952c5642@infradead.org> <20170830152314.0486fafb@lwn.net> <3390facf-69ae-ba18-8abe-09b5695a6b31@infradead.org> <20170830191553.179a79d6@vento.lan> <20170830163139.1abf9baa@lwn.net> <228e1748-37dc-1e1e-d5ec-f35e6bfb5636@infradead.org> <9bbf28b9-73be-04a2-fa7b-0c3a56ed03bb@infradead.org> Message-ID: <4b6e5d98-3030-faa0-bb2d-e8cf3befedbc@infradead.org> Date: Wed, 30 Aug 2017 16:15:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <9bbf28b9-73be-04a2-fa7b-0c3a56ed03bb@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 45 On 08/30/17 16:04, Randy Dunlap wrote: > On 08/30/17 16:01, Randy Dunlap wrote: >> On 08/30/17 15:31, Jonathan Corbet wrote: >>> On Wed, 30 Aug 2017 19:15:53 -0300 >>> Mauro Carvalho Chehab wrote: >>> >>>> I suspect that the problem is not related to the version, but to >>>> what you might have set on LANG. >>>> >>>> Maybe if we add something like: >>>> LANG=C.utf-8 >>>> >>>> to the Documentation/Makefile >>> >>> That's worth a try; Randy, can you give it a quick go? >> >> Yes, that fixes it for me. Thanks. > > Wait! I forgot to unpatch demux.h. I'll test again now.... OK, still works for me. > >>>> or adding: >>>> >>>> .. -*- coding: utf-8; mode: rst -*- >>>> >>>> as the first line on the *.rst file that include the kernel-doc >>>> directive would solve the issue. >>> >>> I guess I don't see how that would help, instead. Emacs reads that line, >>> but it's not involved in the problem. >>> >>> I wish I could reproduce this, then we could see what in that massive >>> try..except block in kerneldoc.py is throwing the exception. Putting in >>> an explicit decode call might be enough to make the problem go away. >> >> >> > > -- ~Randy