Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdHaEso (ORCPT ); Thu, 31 Aug 2017 00:48:44 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35247 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbdHaEsm (ORCPT ); Thu, 31 Aug 2017 00:48:42 -0400 Subject: Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches To: "Gustavo A. R. Silva" , Chaoming Li , Kalle Valo Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170830134223.GA13596@embeddedgus> From: Larry Finger Message-ID: Date: Wed, 30 Aug 2017 23:48:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170830134223.GA13596@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 25 On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226788 > Signed-off-by: Gustavo A. R. Silva > --- > This issue was reported by Coverity and it was tested by compilation only. > I'm suspicious this may be a copy/paste error. Please, verify. > > .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This change is not correct. When bt_link_info->sco_exist is true, the call should be halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC, true, false, 0x5); NACK I will push the correct patch. Larry