Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdHaF7c (ORCPT ); Thu, 31 Aug 2017 01:59:32 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34462 "EHLO mail-oi0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbdHaF7a (ORCPT ); Thu, 31 Aug 2017 01:59:30 -0400 MIME-Version: 1.0 In-Reply-To: <20170830214127.GJ6008@atomide.com> References: <20170830214127.GJ6008@atomide.com> From: Linus Walleij Date: Thu, 31 Aug 2017 07:59:29 +0200 Message-ID: Subject: Re: Regression in next with gpiolib To: Tony Lindgren Cc: Timur Tabi , Grygorii Strashko , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Linux-OMAP Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 26 On Wed, Aug 30, 2017 at 11:41 PM, Tony Lindgren wrote: > Hi Timur, Linus & Grygorii, > > Looks like commit 108d23e322a2 ("gpiolib: request the gpio before > querying its direction") caused a regression on at least pandaboard > es with booting hanging shortly after gpio init. > > It seems to be that we're now calling request and free on all gpios > before they are properly configured? > > I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where > not calling omap_gpio_free() on them makes the system boot again. > > These lines are used for the leds in omap4-panda-common.dtsi, and > omap_gpio_free() will by default set the unused lines for input > and bad things happen. I guess hardware failure could also happen > although I have not seen it here. > > It seems a similar issue can exist on other platforms too, > so it's probably a good idea to revert this for now. I reverted it for now. Yours, Linus Walleij