Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750974AbdHaG2j (ORCPT <rfc822;w@1wt.eu>);
        Thu, 31 Aug 2017 02:28:39 -0400
Received: from smtp.codeaurora.org ([198.145.29.96]:51066 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750732AbdHaG2h (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Aug 2017 02:28:37 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 741DD62D3E
Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org
Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=guptap@codeaurora.org
Subject: Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions
 in stacktrace
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, vbabka@suse.cz, will.deacon@arm.com,
        catalin.marinas@arm.com, iamjoonsoo.kim@lge.com,
        rmk+kernel@arm.linux.org.uk, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
References: <1504078343-28754-1-git-send-email-guptap@codeaurora.org>
 <20170830132828.0bf9b9bc64f51362a64a6694@linux-foundation.org>
From: Prakash Gupta <guptap@codeaurora.org>
Message-ID: <9ce9206f-cffa-99c5-2a34-e5988bd0b603@codeaurora.org>
Date: Thu, 31 Aug 2017 11:58:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170830132828.0bf9b9bc64f51362a64a6694@linux-foundation.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1381
Lines: 39



On 8/31/2017 1:58 AM, Andrew Morton wrote:
> On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <guptap@codeaurora.org> wrote:
> 
>> The stacktraces always begin as follows:
>>
>>   [<c00117b4>] save_stack_trace_tsk+0x0/0x98
>>   [<c0011870>] save_stack_trace+0x24/0x28
>>   ...
>>
>> This is because the stack trace code includes the stack frames for itself.
>> This is incorrect behaviour, and also leads to "skip" doing the wrong thing
>> (which is the number of stack frames to avoid recording.)
>>
>> Perversely, it does the right thing when passed a non-current thread.  Fix
>> this by ensuring that we have a known constant number of frames above the
>> main stack trace function, and always skip these.
>>
>> This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
>> listing stacktrace functions in stacktrace")
> 
> I can take this (with acks, please?)
> 
> 3683f44c42e9 has a cc:stable but your patch does not.  Should it?
> 

My bad, it should be copied to stable as well.

> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of the Code Aurora Forum, hosted by The Linux Foundation