Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdHaGzt (ORCPT ); Thu, 31 Aug 2017 02:55:49 -0400 Received: from mga02.intel.com ([134.134.136.20]:48046 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbdHaGzs (ORCPT ); Thu, 31 Aug 2017 02:55:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,451,1498546800"; d="scan'208";a="895786394" Subject: Re: [PATCH] perf test powerpc: Fix 'Object code reading' test To: Ravi Bangoria , acme@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, namhyung@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au References: <1504161505-5484-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Thu, 31 Aug 2017 09:49:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1504161505-5484-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 42 On 31/08/17 09:38, Ravi Bangoria wrote: > 'Object code reading' test always fails on powerpc. Two reasons for > the failure are: > > 1. When elf section is too big (size beyond 'unsigned int' max value). > objdump fails to disassemble from such section. This was fixed with > commit 0f6329bd7fc ("binutils/objdump: Fix disassemble for huge elf > sections") in binutils. > > 2. When the sample is from hypervisor. Hypervisor symbols can not > be resolved within guest and thus thread__find_addr_map() fails for > such symbols. Fix this by ignoring hypervisor symbols in the test. > > Signed-off-by: Ravi Bangoria > --- > tools/perf/tests/code-reading.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 761c5a4..8702592 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -237,6 +237,10 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > > thread__find_addr_map(thread, cpumode, MAP__FUNCTION, addr, &al); > if (!al.map || !al.map->dso) { > + /* Hyprevisor addr can not be resolved. */ Hyprevisor -> Hypervisor > + if (cpumode == PERF_RECORD_MISC_HYPERVISOR) You need a pr_debug() message here e.g. pr_debug("Hypervisor address can not be resolved - skipping\n"); > + return 0; > + > pr_debug("thread__find_addr_map failed\n"); > return -1; > } >