Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751191AbdHaHwc (ORCPT ); Thu, 31 Aug 2017 03:52:32 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35563 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750733AbdHaHwb (ORCPT ); Thu, 31 Aug 2017 03:52:31 -0400 Date: Thu, 31 Aug 2017 09:52:23 +0200 From: Daniel Vetter To: Himanshu Jha Cc: patrik.r.jakobsson@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/gma500: Remove null check before kfree Message-ID: <20170831072436.m5kemdnm2tz63pes@phenom.ffwll.local> Mail-Followup-To: Himanshu Jha , patrik.r.jakobsson@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1504099556-3887-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504099556-3887-1-git-send-email-himanshujha199640@gmail.com> X-Operating-System: Linux phenom 4.12.0-1-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 41 On Wed, Aug 30, 2017 at 06:55:56PM +0530, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha Applied to drm-misc-next, thanks. -Daniel > --- > drivers/gpu/drm/gma500/cdv_intel_dp.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c > index c52f9ad..a4bb89b 100644 > --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c > +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c > @@ -1901,10 +1901,8 @@ cdv_intel_dp_destroy(struct drm_connector *connector) > > if (is_edp(gma_encoder)) { > /* cdv_intel_panel_destroy_backlight(connector->dev); */ > - if (intel_dp->panel_fixed_mode) { > - kfree(intel_dp->panel_fixed_mode); > - intel_dp->panel_fixed_mode = NULL; > - } > + kfree(intel_dp->panel_fixed_mode); > + intel_dp->panel_fixed_mode = NULL; > } > i2c_del_adapter(&intel_dp->adapter); > drm_connector_unregister(connector); > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch