Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbdHaILs convert rfc822-to-8bit (ORCPT ); Thu, 31 Aug 2017 04:11:48 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:40341 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbdHaILq (ORCPT ); Thu, 31 Aug 2017 04:11:46 -0400 From: Gregory CLEMENT To: Jan Luebbe , Bjorn Helgaas Cc: Andrew Lunn , Thomas Petazzoni , Jason Cooper , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 0/2] fix 4GB DRAM window support on mvebu References: <20170828152517.24506-1-jlu@pengutronix.de> <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> Date: Thu, 31 Aug 2017 10:11:34 +0200 In-Reply-To: <20170830200700.GX8154@bhelgaas-glaptop.roam.corp.google.com> (Bjorn Helgaas's message of "Wed, 30 Aug 2017 15:07:00 -0500") Message-ID: <87y3q017ih.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1586 Lines: 44 Hi Bjorn and Jan, On mer., août 30 2017, Bjorn Helgaas wrote: > On Mon, Aug 28, 2017 at 05:25:15PM +0200, Jan Luebbe wrote: >> The current MBUS DRAM window calculation fails for 4GB windows because it >> overflows. This is fixed in the first patch by using u64 instead of u32 to >> store the size. The second excplicitly checks that we don't try to configure a >> too large memory window in the pci driver. >> >> As they don't depend on each other, they could also go in separatly. >> >> Jan Luebbe (2): >> bus: mbus: fix window size calculation for 4GB windows >> PCI: mvebu: Check DRAM window size >> >> drivers/bus/mvebu-mbus.c | 2 +- >> drivers/pci/host/pci-mvebu.c | 27 ++++++++++++++++++++++----- >> include/linux/mbus.h | 4 ++-- >> 3 files changed, 25 insertions(+), 8 deletions(-) > > Since these can be applied separately, I'll let somebody else take care of > the drivers/bus/mvebu-mbus.c part. I think I am the one who should take it. I will apply it when v4.14-rc1 will be released as it is too late for me for 4.14 now. However I am not against the fact that it is applied through an other tree because we don't touch this file for the next release so there is no risk for a conflict, I can give my Acked-by if needed. Thanks, Gregory > > I'll look for an ack from Thomas or Jason before applying the second patch, > which touches drivers/pci/host/pci-mvebu.c. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com