Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751434AbdHaIPW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 31 Aug 2017 04:15:22 -0400
Received: from Galois.linutronix.de ([146.0.238.70]:59173 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750884AbdHaIPL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Aug 2017 04:15:11 -0400
Date: Thu, 31 Aug 2017 10:15:05 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
cc: Borislav Petkov <bp@alien8.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>
Subject: Re: WARNING: possible circular locking dependency detected
In-Reply-To: <20170831080922.daaypuxatenmpkfo@hirez.programming.kicks-ass.net>
Message-ID: <alpine.DEB.2.20.1708311011050.1874@nanos>
References: <20170825100304.5cwrlrfwi7f3zcld@pd.tnic> <20170828145808.btuqpe2bvxymljyg@hirez.programming.kicks-ass.net> <alpine.DEB.2.20.1708291921350.2408@nanos> <20170829194948.GD32112@worktop.programming.kicks-ass.net> <alpine.DEB.2.20.1708292155360.2696@nanos>
 <20170830054730.GF32112@worktop.programming.kicks-ass.net> <alpine.DEB.2.20.1708310757430.1874@nanos> <20170831073739.ytexc7omldyb5lgy@hirez.programming.kicks-ass.net> <alpine.DEB.2.20.1708310952490.1874@nanos>
 <20170831080922.daaypuxatenmpkfo@hirez.programming.kicks-ass.net>
User-Agent: Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 908
Lines: 27

On Thu, 31 Aug 2017, Peter Zijlstra wrote:

> On Thu, Aug 31, 2017 at 09:55:57AM +0200, Thomas Gleixner wrote:
> > > Arghh!!!
> > > 
> > > And allowing us to create events for offline CPUs (possible I think, but
> > > maybe slightly tricky) won't solve that, because we're already holding
> > > the hotplug_lock during PREPARE.
> > 
> > There are two ways to cure that:
> > 
> > 1) Have a pre cpus_write_lock() stage which is serialized via
> >    cpus_add_remove_lock, which is the outer lock for hotplug.
> > 
> >    There we can sanely create stuff and fail with all consequences.
> 
> True, if you're willing to add more state to that hotplug thing I'll try
> and make that perf patch that allows attaching to offline CPUs.

Now that I think more about it. That's going to be an interesting exercise
vs. the hotplug state registration which relies on cpus_read_lock()
serialization.....

Thanks,

	tglx