Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751009AbdHaIyU (ORCPT ); Thu, 31 Aug 2017 04:54:20 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:35760 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750790AbdHaIyQ (ORCPT ); Thu, 31 Aug 2017 04:54:16 -0400 X-IronPort-AV: E=Sophos;i="5.41,451,1498489200"; d="scan'208";a="256474056" From: Yoshihiro Shimoda To: Geert Uytterhoeven CC: Kishon Vijay Abraham I , "linux-kernel@vger.kernel.org" , Linux-Renesas Subject: RE: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins Thread-Topic: [PATCH 3/4] phy: rcar-gen3-usb2: add SoC-specific parameter for dedicated pins Thread-Index: AQHTIiuiMA+OjM4lT0qhtJ3294whSKKeF3mAgAADGNCAAAbtgIAAAcfg Date: Thu, 31 Aug 2017 08:35:11 +0000 Message-ID: References: <1504164672-20677-1-git-send-email-yoshihiro.shimoda.uh@renesas.com> <1504164672-20677-4-git-send-email-yoshihiro.shimoda.uh@renesas.com> In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.139] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0800;20:8/wF5ccSVhSSXyn2Gi165FwdEYVlS2Cfbn/V41xLzMLUt61FyIGbrZ7GxFSsL0jmBsHClO5hccK1eJvTlbRzk5FM4qq+OHBKCnYIA0z/FrkPrXGtdFGTGkVCKrerR0G0EmKKzvBhfO1VRcw4PswyvPurWBJ2L6kEXyQoHUR8GhQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: a8a61c72-ee81-419a-b30d-08d4f04b31f6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:TY1PR06MB0800; x-ms-traffictypediagnostic: TY1PR06MB0800: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:TY1PR06MB0800;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:TY1PR06MB0800; x-forefront-prvs: 04163EF38A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(24454002)(199003)(377454003)(189002)(3280700002)(105586002)(25786009)(6246003)(86362001)(53546010)(6506006)(7696004)(305945005)(8676002)(5660300001)(53936002)(7736002)(101416001)(77096006)(54906002)(33656002)(106356001)(8936002)(93886005)(97736004)(4326008)(189998001)(2906002)(55016002)(3846002)(2900100001)(74316002)(81156014)(230783001)(50986999)(76176999)(110136004)(102836003)(14454004)(9686003)(99286003)(6116002)(6436002)(3660700001)(2950100002)(68736007)(6916009)(54356999)(66066001)(478600001)(229853002)(81166006);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0800;H:TY1PR06MB0992.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2017 08:35:11.5984 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7V8sU4O013100 Content-Length: 1749 Lines: 53 Hi Geert-san, > From: Geert Uytterhoeven > Sent: Thursday, August 31, 2017 5:27 PM > > Hi Shimoda-san, > > On Thu, Aug 31, 2017 at 10:15 AM, Yoshihiro Shimoda > wrote: > >> From: Geert Uytterhoeven > >> Sent: Thursday, August 31, 2017 4:51 PM > >> On Thu, Aug 31, 2017 at 9:31 AM, Yoshihiro Shimoda > >> wrote: < snip > > >> Given the generic R-Car Gen3 entry sets RCAR_GEN3_PHY_HAS_DEDICATED_PINS, you > >> cannot specify the fallback compatible value of "renesas,rcar-gen3-usb2-phy" > >> in the R-Car D3 .dtsi. > > > > I understood it. > > > >> So I'm wondering, does the USB2 PHY still work (with limitations) on R-Car H3 > >> and M3-W if you drop RCAR_GEN3_PHY_HAS_DEDICATED_PINS? > > > > Yes, the USB PHY still work with limitation (otg capability channel works as > > peripheral mode only. Other channels are no limitation). > > That's good to hear. > > >> If yes, you can drop the flag from the generic entry, and R-Car D3 can specify > >> the generic fallback compatible value in its .dtsi, like H3 and M3-W. > > > > I got it. I will fix this patch set. > > And you can drop the driver change from "[PATCH 4/4] phy: rcar-gen3-usb2: add > binding for r8a77995", as it will match against the generic fallback on D3. I got it. I will submit v2 patches soon. Best regards, Yoshihiro Shimoda > Thanks. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds